Skip to content

Pull from upstream; changes to 'main.py' conflict with GENER work#42

Merged
ptomasula merged 1 commit intoLimnoTech:developfrom
respec:develop
Sep 3, 2021
Merged

Pull from upstream; changes to 'main.py' conflict with GENER work#42
ptomasula merged 1 commit intoLimnoTech:developfrom
respec:develop

Conversation

@aufdenkampe
Copy link
Copy Markdown
Member

Looks like respec@fcc2ee8 (main.py -- better handle subscripts for naming timeseries from external sources) from last Friday may have conflicting code with the new GENER code.

@ptomasula, can you resolve this merge conflict?

@aufdenkampe
Copy link
Copy Markdown
Member Author

aufdenkampe commented Sep 2, 2021

@tredder75, I see that you just merged the GENER stuff from @ptomasula into your branch with commit b3b2435.

There's a commit from @PaulDudaRESPEC that I just noticed that has a minor merge conflict that you'll want to resolve (with @ptomasula) before too long. See below.

@ptomasula ptomasula merged commit db1f2e2 into LimnoTech:develop Sep 3, 2021
@ptomasula
Copy link
Copy Markdown
Member

@aufdenkampe @PaulDudaRESPEC
This was a pretty simple merge conflict to resolve. Paul Duda's work was on the get_timeseries function. The GENER required moving get_timeseries function to the utilities.py file to avoid a circular reference. That's why there was a merge conflict.

I merged in Paul Duda's update and then moved the updated get_timeseries and expand_timeseries_names function to utilities.py. This resolved the merge conflict and I've confirmed the model code still executes for our GLWACSO test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants