fix(character): support integer type for lorebook entry position#54
Open
GentleBurr wants to merge 1 commit into
Open
fix(character): support integer type for lorebook entry position#54GentleBurr wants to merge 1 commit into
GentleBurr wants to merge 1 commit into
Conversation
Change the `position` field type in `CharaCardCharacterBookEntry` to handle both integers and strings during JSON deserialization. Some character card exporters output this property as an integer index rather than a string descriptor, which previously caused the entire import process to fail due to a Serde type mismatch.
Contributor
|
Have you tested the fix on multiple cards? |
Contributor
Author
|
All of my backup cards that I picked randomly to test are still functioning and I've only stumbled upon that new one card so far that necessitates the fix—hard to find them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the
positionfield type inCharaCardCharacterBookEntryto handle both integers and strings during JSON deserialization. Some character card exporters output this property as an integer index rather than a string descriptor, which previously caused the entire import process to fail due to a Serde type mismatch.