Change and remove FunctionsEngine functions#129
Conversation
BREAKING CHANGES Change parameters order revision is now optional Add summary parameter
BREAKING CHANGE Change parameter order reason is now optional
Move format force to json to mediawiki_api_call() Add Exception if format is not json
Remove FunctionsEngine.get_linked_by() and FunctionsEngine.delete_item() WikibaseIntegrator will only support wikibase-oriented functions.
Move _sparql_query_result_to_df() to the end of FunctionsEngine
|
@dpriskorn What do you think about these changes? I remove some API calls who are not wikibase related. |
I never used any of them. For the sparql->dataframe I see it as something not belonging in WBI. I recently started using https://github.com/njanakiev/sparqldataframe which works perfect. |
* Rename delete_statements to remove_claims * Rename get_search_results to search_entities
sparqldataframe seems to do the same as |
Use sparqldataframe instead
|
I removed dataframe support in WikibaseIntegrator. |
Support python 3.10
|
Issue with pytest for Python 3.10 check : |
Because beta1 from Github actions is bogus
|
Very nice 😃 Congratulations! |
FunctionsEngine.mediawiki_api_call().pandasas a dependency.BREAKING CHANGES
wbi_core.FunctionsEnginebywbi_functions.FunctionsEngine.get_linked_by()andFunctionsEngine.delete_item(). WikibaseIntegrator will only support wikibase-oriented functions. Directly usewbi_functions.mediawiki_api_call_helperinstead.FunctionsEngine.delete_statement()towbi_functions.remove_claims().revisionparameter in now optional.summaryparameter.FunctionsEngine.get_search_results()towbi_functions.search_entities().wbi_functions.execute_sparql_query, use sparqldataframe package instead.wbi_functions.mediawiki_api_call().