fix(deps): switch xunit to mtp-v2 and fix Scriban build error#309
Merged
Conversation
- Updated `xunit.v3` to `xunit.v3.mtp-v2` in multiple test projects.
- Introduced `System.Text.Json` as a dependency in `MinimalLambda.SourceGenerators.csproj`.
- Bumped versions for various dependencies in `Directory.Packages.props`:
- `Amazon.Lambda.Core` to `2.8.1`.
- `Amazon.Lambda.RuntimeSupport` to `1.14.2`.
- `AWSSDK.Core` to `4.0.3.20`.
- `Microsoft.CodeAnalysis`, `Microsoft.CodeAnalysis.CSharp`, and related packages to `5.3.0`.
- `OpenTelemetry.Exporter.InMemory`, `OpenTelemetry.Exporter.OpenTelemetryProtocol`,
and `OpenTelemetry.Extensions.Hosting` to `1.15.0`.
- `Verify.XunitV3` to `31.13.5`.
- Locked `System.Text.Json` for `netstandard2.0` targets and applied version ranges for `.net8+`.
…ages.props` - Refined version ranges for `Microsoft.Extensions.Hosting` and related packages: - Locked to `[9.0.14, 10.0.0)` for `net9.0`. - Locked to `[10.0.5, 11.0.0)` for `net10.0`. - Applied consistent version range approach for `.net8+` frameworks. - Removed outdated comments regarding version locking.
- Standardized spacing for `<PackageVersion>` elements in `Directory.Packages.props`. - Updated `Amazon.Lambda.KinesisEvents` to version `3.0.2`. - Bumped `System.Text.Json` to `8.0.6` for `netstandard2.0`. - Ensured consistent version ranges in conditional `.net` framework target groups.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #309 +/- ##
==========================================
+ Coverage 87.35% 87.38% +0.02%
==========================================
Files 131 113 -18
Lines 2919 2814 -105
Branches 351 351
==========================================
- Hits 2550 2459 -91
+ Misses 268 254 -14
Partials 101 101 see 43 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
📋 Summary
Two related fixes to restore a clean build and working tests:
System.Text.Json-dependent source files that fail to compile againstnetstandard2.0. AddedSystem.Text.Jsonas a package reference toMinimalLambda.SourceGeneratorsso those sources compile correctly.xunit.v3.mtp-v2: All test projects were referencingxunit.v3; switched toxunit.v3.mtp-v2which is the correct package for use with the Microsoft.Testing.Platform runner (pinned inglobal.json).Directory.Packages.props:Amazon.Lambda.Core,Amazon.Lambda.KinesisEvents,Amazon.Lambda.RuntimeSupport,Microsoft.Extensions.*,Microsoft.SourceLink.GitHub,Microsoft.CodeAnalysis.*, and others brought up to current patch/minor releases.✅ Checklist
🧪 Related Issues or PRs
N/A
💬 Notes for Reviewers
The
System.Text.Jsonreference on the source generator project is scoped only to build assets (PrivateAssets="all") so it does not leak into consuming projects.