chore: migrate InternalsVisibleTo declarations to project files#265
Merged
j-d-ha merged 4 commits intoDec 21, 2025
Merged
Conversation
…ules - Updated MinimalLambda.sln.DotSettings to set CheckNamespace inspection severity to DO_NOT_SHOW.
…files - Removed `InternalsVisibleTo` attributes from AssemblyInfo.cs files. - Added `InternalsVisibleTo` declarations directly to project files across all relevant projects.
j-d-ha
enabled auto-merge (squash)
December 21, 2025 18:09
j-d-ha
changed the title
- Updated descriptions for `<type>` and `<scope>` to specify "Valid values are" for clarity.
- Updated the description to indicate that `<scope>` is optional.
|
j-d-ha
deleted the
feature/#262-migrate-AssemblyInfo.cs-to-csproj-properties
branch
December 21, 2025 18:14
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #265 +/- ##
==========================================
- Coverage 88.76% 88.73% -0.04%
==========================================
Files 132 132
Lines 3231 3231
Branches 321 321
==========================================
- Hits 2868 2867 -1
- Misses 247 248 +1
Partials 116 116 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
📋 Summary
Migrates
InternalsVisibleToassembly attribute declarations fromAssemblyInfo.csfiles to MSBuild<InternalsVisibleTo>items in.csprojfiles. This modernizes the project structure by using the more declarative MSBuild approach over traditional assembly attributes.This change also disables namespace check highlighting in ReSharper inspection rules to reduce noise in the IDE.
Changes:
Properties/AssemblyInfo.csfiles from all projects (7 files deleted)<InternalsVisibleTo>items to.csprojfiles for:MinimalLambdaMinimalLambda.SourceGeneratorsMinimalLambda.TestingMinimalLambda.sln.DotSettingsto disableCheckNamespaceinspection✅ Checklist
🧪 Related Issues or PRs
Closes #262
💬 Notes for Reviewers
This is a purely structural change with no functional impact. The
InternalsVisibleTodeclarations remain identical, just moved from C# code to MSBuild project files. All deletedAssemblyInfo.csfiles contained onlyInternalsVisibleTodeclarations.