Conversation
chawes13
approved these changes
Nov 20, 2020
Contributor
chawes13
left a comment
chawes13
left a comment
There was a problem hiding this comment.
I absolutely love the name of this PR! 🧹 🍂
When I was regression testing the components I did notice that the storybook styling for the checkbox with a tooltip was a little wonky. Is that something that you think should be taken care of? And if so, would it qualify as clean-up for this PR or would you want to handle that separately?
Contributor
|
@marchwiany Could you review this comment and let me know what you think? #459 (review) |
Contributor
Author
|
@chawes13 pushed changes to address comment! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed a bunch of project specific files that didn't need to be in here.
Author Checklist