F-039 (P8) — `DockerUpdateGuard.csproj`: duplicate property & non-deterministic release build

[LarsLaskowski]

Severity: 🔵 · Criterion: K9 / K12 · Phase: P8 · Status (review): 🆕

File(s): src/DockerUpdateGuard/DockerUpdateGuard.csproj:8,11,18,24; SharedAssemblyInfo.cs:13

Finding

<GenerateDocumentationFile>True is declared twice (:8 and :11). <Deterministic>False is set for Debug and Release (:18,:24) — necessary because SharedAssemblyInfo.cs:13 uses AssemblyVersion("1.0.*") (wildcard), which precludes deterministic builds. Consequence: release builds are not reproducible, and AssemblyVersion is always 1.0.<auto> (the real version is correctly in InformationalVersion/FileVersion/DisplayVersion).

Impact

Cosmetic redundancy; non-reproducible release assemblies. Practically uncritical, since display/diagnostics run via InformationalVersion/DisplayVersion.

Recommendation

Remove the duplicate GenerateDocumentationFile line. If reproducible builds are desired: use a fixed AssemblyVersion (e.g. from $(Version)) instead of 1.0.* and leave Deterministic at its default (true).

---

_{Auto-generated from the repository code review. Source of truth: docs/review/findings.md → F-039 (P8), branch review/review-analysis-plan.}