Item 7767: Render new error page#54
Merged
Merged
Conversation
cnathe
reviewed
Sep 28, 2020
cnathe
left a comment
cnathe
left a comment
There was a problem hiding this comment.
Change looks good to me, but I'll defer to @labkey-nicka on these server side changes.
labkey-nicka
requested changes
Sep 28, 2020
labkey-nicka
approved these changes
Sep 29, 2020
labkey-nicka
left a comment
labkey-nicka
left a comment
There was a problem hiding this comment.
Looks good. Only a nit regarding imports.
| import org.labkey.api.assay.AssayProvider; | ||
| import org.labkey.api.assay.AssayService; | ||
| import org.labkey.api.util.ErrorRenderer; | ||
| import org.labkey.api.util.ErrorView; |
There was a problem hiding this comment.
nit: Please clean up these imports now that they are no longer used.
bbimber
added a commit
that referenced
this pull request
Dec 3, 2025
Merge discvr-25.7 to discvr-25.11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR updates the CreateTemplateAction to return the new error page instead of old.
Related Pull Requests