Improve start page shadow in dark theme#910
Merged
KirillOsenkov merged 1 commit intoKirillOsenkov:mainfrom Dec 3, 2025
Merged
Conversation
In dark theme, the shadow was lighter than the background, so it was more of a glow than a shadow, which looked a bit off. This approach uses opacity to blend with whatever background the theme chooses. I made it a bit smaller too, so it was more noticeable in dark mode.
Owner
|
lol the glow was accidental but I kinda liked it :) ah well |
KirillOsenkov
approved these changes
Dec 3, 2025
Contributor
Author
|
I don't feel strongly. Feel free to revert! |
This was referenced Apr 1, 2026
This was referenced Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In dark theme, the shadow was lighter than the background, so it was more of a glow than a shadow, which looked a bit off.
This approach uses opacity to blend with whatever background the theme chooses. I made it a bit smaller too, so it was more noticeable in dark mode.
Before
After