fix: expand DataValue::Utf8 so that it can correspond to Char and Varchar respectively.#183
Merged
KKould merged 3 commits intoKipData:mainfrom Mar 26, 2024
Merged
fix: expand DataValue::Utf8 so that it can correspond to Char and Varchar respectively.#183KKould merged 3 commits intoKipData:mainfrom
DataValue::Utf8 so that it can correspond to Char and Varchar respectively.#183KKould merged 3 commits intoKipData:mainfrom
Conversation
… `VarChar` respectively.
Member
|
Is this a necessary change? can you give me some situations |
Member
Author
This pr is mainly due to the |
crwen
approved these changes
Mar 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
originally, both
LogicalType::CharandLogicalType::VarcharusedDataValue::Utf8, butDataValue::Utf8does not know its own logical_typeCode changes
Check List
Tests
Side effects
Note for reviewer