Skip to content

feat: Change ConsoleAppFramework to Cocona#14

Merged
guitarrapc merged 7 commits intomasterfrom
feat/cocona
Jan 28, 2020
Merged

feat: Change ConsoleAppFramework to Cocona#14
guitarrapc merged 7 commits intomasterfrom
feat/cocona

Conversation

@guitarrapc
Copy link
Collaborator

@guitarrapc guitarrapc commented Jan 27, 2020

ref: #13

Summary

Change Console Framework To Cocona.
Cocona is match Unix-friendly well designed CLI.
This offer me use to use --longname and -shortname. Also merge flag -db is available.

TODO

I must promise following before merge.

  • Make sure Cli input argument are not broke. (Make tests)
    • query
    • file
    • dir
$ mysqltocsharp dir -i ../../../../../samples/tables -o ../../../../../samples/MySQLToCsharpSampleConsoleApp -n MySQLToCsharpSampleConsoleApp
  • Make sure Output Class is not changed. (Make tests)
    • query
    • file
    • dir
[-] skipped: BinaryData.cs (no change)
[-] skipped: Character.cs (no change)
[-] skipped: CharacterSlot.cs (no change)
[-] skipped: Multi.cs (no change)
[-] skipped: Player.cs (no change)
[-] skipped: Room.cs (no change)
[-] skipped: String.cs (no change)
[-] skipped: Weapon.cs (no change)

@guitarrapc guitarrapc self-assigned this Jan 27, 2020
@codecov
Copy link

codecov bot commented Jan 27, 2020

Codecov Report

Merging #14 into master will increase coverage by 45.97%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #14       +/-   ##
==========================================
+ Coverage   27.93%   73.9%   +45.97%     
==========================================
  Files          17      13        -4     
  Lines       47198     958    -46240     
==========================================
- Hits        13184     708    -12476     
+ Misses      34014     250    -33764
Impacted Files Coverage Δ
...ypeConverters/StandardDateTimeAsOffsetConverter.cs 92.59% <ø> (ø) ⬆️
...sharp/TypeConverters/StandardBitAsBoolConverter.cs 96.29% <ø> (ø) ⬆️
.../MySQLToCsharp/TypeConverters/StandardConverter.cs 96.29% <100%> (ø) ⬆️
src/MySQLToCsharp/Generator.cs 70.32% <66.66%> (+70.32%) ⬆️
src/MySQLToCsharp/Program.cs 87.5% <86.2%> (+87.5%) ⬆️
...c/MySQLToCsharp.Parser/Parsers/MySql/MySqlLexer.cs
...arp.Parser/Parsers/MySql/MySqlParserBaseVisitor.cs
...rp.Parser/Parsers/MySql/MySqlParserBaseListener.cs
.../MySQLToCsharp.Parser/Parsers/MySql/MySqlParser.cs
src/MySQLToCsharp.Parser/Parsers/Parser.cs 56.94% <0%> (+26.38%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d90ecce...d53403f. Read the comment docs.

@guitarrapc guitarrapc changed the title [wip] feat: Change ConsoleAppFramework to Cocona feat: Change ConsoleAppFramework to Cocona Jan 28, 2020
@guitarrapc guitarrapc merged commit 676163e into master Jan 28, 2020
@guitarrapc guitarrapc deleted the feat/cocona branch January 28, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant