MSL: Treat pointer to vector as scalar type when bitcasting#2452
Merged
HansKristian-Work merged 1 commit intoKhronosGroup:mainfrom Mar 10, 2025
Merged
MSL: Treat pointer to vector as scalar type when bitcasting#2452HansKristian-Work merged 1 commit intoKhronosGroup:mainfrom
HansKristian-Work merged 1 commit intoKhronosGroup:mainfrom
Conversation
cdavis5e
suggested changes
Mar 3, 2025
Contributor
cdavis5e
left a comment
cdavis5e
left a comment
There was a problem hiding this comment.
The change itself looks good, but needs a test case.
Contributor
|
Can confirm this fixes the shader issue I had, thanks! |
Otherwise, they will be misregarded as vectors and can be used in as_type, which does not support pointer type as destination.
Contributor
Author
|
I added a test case taken from the original bug report. It's a little bit long but glslang doesn't generate the spirv I want and I'm not proficient enough to edit raw spirv assembly. |
cdavis5e
approved these changes
Mar 4, 2025
Contributor
cdavis5e
left a comment
cdavis5e
left a comment
There was a problem hiding this comment.
LGTM, FWIW. But, I lack authority to merge changes to this repo. H-K tends to be away from this project for long periods. You'll have to wait till he gets back--and he may have feedback of his own.
Contributor
|
Seems correct, but it's using the wrong way to check for is_pointer. It's also done "wrong" in the surrounding code, so I'll just fix that as a follow-up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, they will be misregarded as vectors and can be used in as_type, which does not support pointer type as destination.
Fixes #2451