Skip to content

Enterprise commands bug fixes #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adeshmukh-ks wants to merge 3 commits into
base: enterprise-command-bug-fix
Choose a base branch
from
Open

Enterprise commands bug fixes #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2143bce
enterprise edit node change bug fix
adeshmukh-ks Jun 5, 2026
a6b74f2
enterprise-user edit node change bug fix
adeshmukh-ks Jun 5, 2026
2c98f0b
parent_id initialization fix
adeshmukh-ks Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion keepercli-package/src/keepercli/commands/enterprise_role.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ def execute(self, context: KeeperParams, **kwargs) -> None:
parent_node = enterprise_utils.NodeUtils.resolve_single_node(context.enterprise_data, kwargs.get('parent'))
parent_id = parent_node.node_id
else:
parent_id = context.enterprise_data.root_node.node_id
parent_id = role_list[0].node_id

new_user_inherit: Optional[bool] = None
visible_below: Optional[bool] = None
Expand Down
6 changes: 2 additions & 4 deletions keepercli-package/src/keepercli/commands/enterprise_user.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,12 +540,10 @@ def execute(self, context: KeeperParams, **kwargs) -> None:
if not emails:
raise base.CommandError('No email(s) provided')

parent_id: Optional[int]
parent_id: Optional[int] = None
if kwargs.get('parent'):
parent_node = enterprise_utils.NodeUtils.resolve_single_node(context.enterprise_data, kwargs.get('parent'))
parent_id = parent_node.node_id
else:
parent_id = context.enterprise_data.root_node.node_id

users = enterprise_utils.UserUtils.resolve_existing_users(context.enterprise_data, emails)
if not users:
Expand Down Expand Up @@ -603,7 +601,7 @@ def execute(self, context: KeeperParams, **kwargs) -> None:

if parent_id or full_name or job_title:
users_to_update = [enterprise_management.UserEdit(
enterprise_user_id=x.enterprise_user_id, node_id=parent_id, full_name=full_name, job_title=job_title)
enterprise_user_id=x.enterprise_user_id, node_id=parent_id or x.node_id, full_name=full_name, job_title=job_title)
for x in users]
batch.modify_users(to_update=users_to_update)

Expand Down
3 changes: 2 additions & 1 deletion keepercli-package/src/keepercli/commands/enterprise_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ def enforcement_value_from_file(filepath: str) -> str:
def parse_enforcements(enforcement_names: Any) -> Tuple[Dict[str, Any], List[str]]:
enforcements: Dict[str, Any] = {}
errors: List[str] = []
if isinstance(enforcements, str):
if isinstance(enforcement_names, str):
enforcement_names = [enforcement_names]
file_prefix = '$FILE='
for enf in enforcement_names:
Expand Down Expand Up @@ -232,6 +232,7 @@ def parse_enforcements(enforcement_names: Any) -> Tuple[Dict[str, Any], List[str
else:
errors.append(f'Enforcement {key} is skipped. Expected format: KEY:$FILE=<FILEPATH>')
continue
enforcements[key] = enforcement_value
return enforcements, errors


Expand Down