pam launch: don't show guacd_error notice on normal logout#2126
Merged
Conversation
sk-keeper
pushed a commit
that referenced
this pull request
Jun 5, 2026
jpkeepersecurity
pushed a commit
that referenced
this pull request
Jun 9, 2026
sshrushanth-ks
pushed a commit
that referenced
this pull request
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a clean logout (typing exit), the gateway reports the guacd-initiated disconnect as guacd_error (CloseConnectionReason 14), so pam launch printed a misleading
Session ended (guacd_error).Treat guacd_error as a normal close once the session was live (≥1 sync), and server_disconnect as clean always; a guacd_error before any data flowed (real connect-time fault) is still surfaced.