Read OASIS files with large property strings#2319
Closed
abdelq wants to merge 5 commits intoKLayout:masterfrom
Closed
Read OASIS files with large property strings#2319abdelq wants to merge 5 commits intoKLayout:masterfrom
abdelq wants to merge 5 commits intoKLayout:masterfrom
Conversation
|
Could you comment on what kind of metadata takes up 42k characters ? |
Collaborator
|
Thanks for the PR, but: could you please first file an issue and give me a chance to look at that? The buffer length should not have anything to do with the maximum number of bytes you can read into a string. If that is limited, the problem is somewhere else and the solution should not be OASIS specific. Matthias |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have some OAS files written by KLayout (through Kfactory) that can't be opened with it because of large metadata strings (e.g. JSON blobs).
I've also had to make some changes to
RPATHin order to be able to run KLayout and the test.I've avoided changing the
InflateFilterlogic, since I'm making the assumption that there is are performance concerns regarding the fixed buffer size.