Stop IsolateHolderService when app is killed with swipe to remove#10
Merged
Conversation
Owner
|
Thank you very much for your pull request. I tested it and it indeed fixes the problem you encountered. As this would be a new version, could you please increase the After that, LGTM. |
Contributor
Author
|
All done! :) |
Owner
|
Thank you very much :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
This package is great and I am using it well.
and I am appreciated your work.
I can stop IsolateHolderService with stop "FlutterBackground.disableBackgroundExecution()".
But when I kill app with swipe to remove action at recent apps, the service is still there.
I googled and found this solution.
This is my first time to create PR and I am not sure this is right way.
But I wish this will help you.
If you feel bad, please ignore this PR.