Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## dev #53 +/- ##
==========================================
- Coverage 93.16% 92.92% -0.24%
==========================================
Files 4 3 -1
Lines 395 396 +1
==========================================
Hits 368 368
- Misses 27 28 +1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ablaom
reviewed
Mar 20, 2023
ablaom
reviewed
Mar 20, 2023
ablaom
reviewed
Mar 20, 2023
ablaom
reviewed
Mar 20, 2023
ablaom
reviewed
Mar 20, 2023
ablaom
reviewed
Mar 20, 2023
ablaom
reviewed
Mar 20, 2023
ablaom
reviewed
Mar 20, 2023
ablaom
reviewed
Mar 20, 2023
ablaom
reviewed
Mar 20, 2023
ablaom
reviewed
Mar 20, 2023
ablaom
reviewed
Mar 20, 2023
ablaom
reviewed
Mar 20, 2023
ablaom
reviewed
Mar 20, 2023
ablaom
reviewed
Mar 20, 2023
ablaom
reviewed
Mar 20, 2023
ablaom
reviewed
Mar 20, 2023
Member
There was a problem hiding this comment.
Great to have this @OkonSamuel .
Apart from the comments above:
- We need to move the docstrings so that they occur after the metadata declaration because the docstring header interpolator is not working:
A model type for constructing a multitarget knn regressor, based on unknown.jl (unknown), and implementing
the MLJ model interface.
- I suggest we declare
human_nametraits, eg
human_name = "K-nearest neighbor classifier"to make the doc header read better.
Co-authored-by: Anthony Blaom, PhD <anthony.blaom@gmail.com>
Co-authored-by: Anthony Blaom, PhD <anthony.blaom@gmail.com>
ablaom
reviewed
Mar 21, 2023
ablaom
reviewed
Mar 21, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #51