Skip to content

Create documentation#36

Merged
ablaom merged 6 commits intodevfrom
docfixes
Mar 3, 2021
Merged

Create documentation#36
ablaom merged 6 commits intodevfrom
docfixes

Conversation

@OkonSamuel
Copy link
Copy Markdown
Member

No description provided.

@OkonSamuel OkonSamuel requested a review from ablaom March 1, 2021 19:01
Comment thread docs/src/index.md Outdated
Comment thread docs/src/index.md Outdated
Copy link
Copy Markdown
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, a simple readme documentation probably sufficed, but this is awesome! 🎉

I'm not a super expert on Documenter generation, so there may be technical details I'm missing. It looks good to me.

I see that you wrap all the codes in "literal" julia blocks, rather than auto-generating them by using @example or @repl blocks (see here). That's fine, if you have very carefully checked all the code blocks evaluate. Debugging the auto-generating ones can be very tedious, so I don't have a strong opinion.

@ablaom
Copy link
Copy Markdown
Member

ablaom commented Mar 2, 2021

We will need to setup secret/deploy keys to enable deployment of the documentation onto gh pages during CI. Let me know if you want me to set that up.

@OkonSamuel
Copy link
Copy Markdown
Member Author

OkonSamuel commented Mar 2, 2021

I see that you wrap all the codes in "literal" julia blocks, rather than auto-generating them by using @example or @repl blocks (see here). That's fine, if you have very carefully checked all the code blocks evaluate. Debugging the auto-generating ones can be very tedious, so I don't have a strong opinion.

Yeah. I just added a few doctests.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 2, 2021

Codecov Report

Merging #36 (940f6e9) into dev (11f13b1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev      #36   +/-   ##
=======================================
  Coverage   91.30%   91.30%           
=======================================
  Files           4        4           
  Lines         299      299           
=======================================
  Hits          273      273           
  Misses         26       26           
Impacted Files Coverage Δ
src/kernels.jl 88.65% <ø> (ø)
src/models.jl 89.28% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11f13b1...940f6e9. Read the comment docs.

@OkonSamuel
Copy link
Copy Markdown
Member Author

We will need to setup secret/deploy keys to enable deployment of the documentation onto gh pages during CI. Let me know if you want me to set that up.

I have done this. But this #PR has to be merged unto dev and then unto master for the documentation to build.
build_docs = (base_ref == "master") && (head_ref == "dev") && (base_repository == head_repository)

Comment thread docs/src/index.md
using NearestNeighborModels, MLJ
X, y = @load_crabs; # loads the crabs dataset from MLJ
train_inds, test_inds = partition(1:nrows(X), 0.7, shuffle=false, rng=100);
train_inds, test_inds = partition(1:nrows(X), 0.7, shuffle=false);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(just FYI: You can leave shuffle=false out, as it's the default; no harm leaving it in for clarity)

@ablaom ablaom merged commit aa847e8 into dev Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants