Conversation
There was a problem hiding this comment.
Okay, a simple readme documentation probably sufficed, but this is awesome! 🎉
I'm not a super expert on Documenter generation, so there may be technical details I'm missing. It looks good to me.
I see that you wrap all the codes in "literal" julia blocks, rather than auto-generating them by using @example or @repl blocks (see here). That's fine, if you have very carefully checked all the code blocks evaluate. Debugging the auto-generating ones can be very tedious, so I don't have a strong opinion.
|
We will need to setup secret/deploy keys to enable deployment of the documentation onto gh pages during CI. Let me know if you want me to set that up. |
Yeah. I just added a few doctests. |
Codecov Report
@@ Coverage Diff @@
## dev #36 +/- ##
=======================================
Coverage 91.30% 91.30%
=======================================
Files 4 4
Lines 299 299
=======================================
Hits 273 273
Misses 26 26
Continue to review full report at Codecov.
|
I have done this. But this #PR has to be merged unto dev and then unto master for the documentation to build. |
| using NearestNeighborModels, MLJ | ||
| X, y = @load_crabs; # loads the crabs dataset from MLJ | ||
| train_inds, test_inds = partition(1:nrows(X), 0.7, shuffle=false, rng=100); | ||
| train_inds, test_inds = partition(1:nrows(X), 0.7, shuffle=false); |
There was a problem hiding this comment.
(just FYI: You can leave shuffle=false out, as it's the default; no harm leaving it in for clarity)
No description provided.