Adding response body in log#21
Open
mabaro3009 wants to merge 5 commits into
Open
Conversation
coboshm
reviewed
Aug 1, 2022
| } | ||
| defer resp.Body.Close() | ||
| for k, v := range resp.Header { | ||
| w.Header()[k] = v |
Contributor
There was a problem hiding this comment.
can we use w.Header().Add(...)?
Author
|
Do not merge, need to take into account PII |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.notion.so/verseapp/obs-pkg-add-responseBody-618cd9b458de4fcdaaf243934b6c42eb
Was not sure how to approach this, ended up with a responseRecorder to later write the headers and body into the responseWriter. This is because I can't read the response from the responseWriter.
Also, added some example urls to test.
Screenshots below that show the response both in localhost and in the log:
OK
Error
With JSON response body
With no response body