Skip to content

test: harden interpreter and observer generator coverage#478

Merged
JerrettDavis merged 1 commit into
mainfrom
coverage/harden-generator-gaps-413-n
May 31, 2026
Merged

test: harden interpreter and observer generator coverage#478
JerrettDavis merged 1 commit into
mainfrom
coverage/harden-generator-gaps-413-n

Conversation

@JerrettDavis

Copy link
Copy Markdown
Owner

Summary

  • add Interpreter diagnostics for blank rule names and invalid terminal/non-terminal method shapes
  • add Observer source-shape coverage for invalid enum configuration fallback defaults
  • move Interpreter generator line coverage over 99%

Refs #413

Verification

  • dotnet test test\PatternKit.Generators.Tests\PatternKit.Generators.Tests.csproj --configuration Release -p:TestTfmsInParallel=false --filter "FullyQualifiedNameObserverGeneratorTests|FullyQualifiedNameInterpreterGeneratorTests"
  • dotnet test test\PatternKit.Generators.Tests\PatternKit.Generators.Tests.csproj --configuration Release -p:TestTfmsInParallel=false --collect:"XPlat Code Coverage" --results-directory TestResults-generators-current -- DataCollectionRunSettings.DataCollectors.DataCollector.Configuration.Format=cobertura
  • PatternKit.Generators coverage: 97.98%
  • InterpreterGenerator coverage: 99.39%

Copilot AI review requested due to automatic review settings May 31, 2026 16:02
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds targeted generator test coverage for the Interpreter and Observer source generators to push line coverage toward 99% (refs #413). The Interpreter test asserts PKINT003 is reported for each of six distinct invalid rule shapes (blank name, void return, generic method, missing parameters, wrong non-terminal first parameter, wrong context type), exercising every branch in TryGetRule. The Observer test asserts that out-of-range enum values for Threading, Exceptions, and Order silently fall back to the documented defaults (Locking / Continue / RegistrationOrder) by checking the generated source shape.

Changes:

  • New Interpreter test covering all PKINT003 invalid-rule branches in a single compilation.
  • New Observer test covering invalid-enum fallback behavior via generated-source assertions.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test/PatternKit.Generators.Tests/InterpreterGeneratorTests.cs Adds ReportsDiagnosticsForInvalidInterpreterRuleShapes asserting six PKINT003 diagnostics.
test/PatternKit.Generators.Tests/ObserverGeneratorTests.cs Adds Invalid_Enum_Configuration_Falls_Back_To_Observer_Defaults verifying default Locking/Continue source shape.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

Copy link
Copy Markdown
Contributor

Test Results

    12 files      12 suites   11m 57s ⏱️
 4 032 tests  4 032 ✅ 0 💤 0 ❌
12 527 runs  12 527 ✅ 0 💤 0 ❌

Results for commit c2a70f8.

@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Summary
  Generated on: 05/31/2026 - 16:09:59
  Coverage date: 05/31/2026 - 16:07:22 - 05/31/2026 - 16:09:47
  Parser: MultiReport (12x Cobertura)
  Assemblies: 5
  Classes: 1715
  Files: 579
  Line coverage: 97.2%
  Covered lines: 45908
  Uncovered lines: 1280
  Coverable lines: 47188
  Total lines: 100757
  Branch coverage: 84% (14520 of 17272)
  Covered branches: 14520
  Total branches: 17272
  Method coverage: 97.2% (8969 of 9225)
  Full method coverage: 91.4% (8440 of 9225)
  Covered methods: 8969
  Fully covered methods: 8440
  Total methods: 9225

PatternKit.Core                                                                                                       96%
  PatternKit.Application.ActivityTracking.ActivityGateState                                                          100%
  PatternKit.Application.ActivityTracking.ActivityLease                                                              100%
  PatternKit.Application.ActivityTracking.ActivityRecord                                                             100%
  PatternKit.Application.ActivityTracking.ActivityTracker                                                            100%
  PatternKit.Application.Aggregates.AggregateCommandHandler<T1, T2, T3>                                              100%
  PatternKit.Application.Aggregates.AggregateCommandResult<T>                                                        100%
  PatternKit.Application.Aggregates.AggregateRoot<T1, T2>                                                            100%
  PatternKit.Application.AntiCorruption.AntiCorruptionLayer<T1, T2>                                                 90.4%
  PatternKit.Application.AntiCorruption.AntiCorruptionResult<T>                                                      100%
  PatternKit.Application.AuditLog.AuditLogAppendResult<T>                                                           85.7%
  PatternKit.Application.AuditLog.InMemoryAuditLog<T1, T2>                                                          95.4%
  PatternKit.Application.BoundedContexts.BoundedContextAdapter                                                       100%
  PatternKit.Application.BoundedContexts.BoundedContextCapability                                                   83.3%
  PatternKit.Application.BoundedContexts.BoundedContextDescriptor                                                   95.4%
  PatternKit.Application.ContextMaps.ContextMapDescriptor                                                           96.8%
  PatternKit.Application.ContextMaps.ContextMapRelationship                                                          100%
  PatternKit.Application.DataMapping.DataMapper<T1, T2>                                                             94.6%
  PatternKit.Application.DataMapping.DataMapperError                                                                  90%
  PatternKit.Application.DataMapping.DataMapperResult<T>                                                            84.6%
  PatternKit.Application.DomainEvents.DomainEventDispatcher<T>                                                      95.4%
  PatternKit.Application.DomainEvents.DomainEventDispatchResult                                                      100%
  PatternKit.Application.DomainServices.DomainServiceOperation<T1, T2>                                               100%
  PatternKit.Application.DomainServices.DomainServiceRegistry<T1, T2>                                                100%
  PatternKit.Application.EventSourcing.EventStoreAppendResult                                                        100%
  PatternKit.Application.EventSourcing.InMemoryEventStore<T1, T2>                                                   97.9%
  PatternKit.Application.EventSourcing.StoredEvent<T1, T2>                                                            80%
  PatternKit.Application.EventualConsistency.EventualConsistencyEvaluation<T>                                       92.3%
  PatternKit.Application.EventualConsistency.EventualConsistencyMonitor<T>                                          97.2%
  PatternKit.Application.EventualConsistency.EventualConsistencyMonitorState<T>                                      100%
  PatternKit.Application.EventualConsistency.EventualConsistencyWatermarks<T>                                       96.7%
  PatternKit.Application.FeatureToggles.FeatureToggleDecision                                                       87.5%
  PatternKit.Application.FeatureToggles.FeatureToggleRule<T>                                                         100%
  PatternKit.Application.FeatureToggles.FeatureToggleSet<T>                                                         96.9%
  PatternKit.Application.IdentityMap.IdentityMap<T1, T2>                                                             100%
  PatternKit.Application.IdentityMap.IdentityMapResult<T>                                                           92.8%
  PatternKit.Application.ManualTaskGates.ManualTaskGate<T>                                                          98.5%
  PatternKit.Application.ManualTaskGates.ManualTaskGateState<T>                                                      100%
  PatternKit.Application.ManualTaskGates.ManualTaskRecord<T>                                                        96.9%

@github-actions

Copy link
Copy Markdown
Contributor

🔍 PR Validation Results

Version: ``

✅ Validation Steps

  • Build solution
  • Run tests
  • Build documentation
  • Dry-run NuGet packaging

📊 Artifacts

Dry-run artifacts have been uploaded and will be available for 7 days.


This comment was automatically generated by the PR validation workflow.

@codecov

codecov Bot commented May 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.38%. Comparing base (869f436) to head (c2a70f8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
+ Coverage   97.28%   97.38%   +0.10%     
==========================================
  Files         579      579              
  Lines       47188    47188              
  Branches     3076     6772    +3696     
==========================================
+ Hits        45906    45954      +48     
+ Misses       1282     1234      -48     
Flag Coverage Δ
unittests 97.38% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JerrettDavis
JerrettDavis merged commit 752f6de into main May 31, 2026
13 checks passed
@JerrettDavis
JerrettDavis deleted the coverage/harden-generator-gaps-413-n branch May 31, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants