test: harden saga generator coverage#477
Merged
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional TinyBDD scenarios to increase Saga source-generator coverage, focusing on global-namespace struct hosts, sync/async factory naming, completion wiring, and invalid step-shape diagnostics (refs #413).
Changes:
- Added a scenario that validates generation for a global-namespace
structhost with both sync and async steps, including custom factory names and completion wiring in both factories. - Added a scenario that exercises PKSG003 diagnostics for invalid saga-step method shapes (non-static method and missing required parameters).
- Introduced a small helper (
CountOccurrences) to assert repeated emission patterns in generated output.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+259
to
+261
| var diagnostics = run.Results.SelectMany(result => result.Diagnostics).ToArray(); | ||
| ScenarioExpect.Equal(2, diagnostics.Count(diagnostic => diagnostic.Id == "PKSG003")); | ||
| } |
Contributor
Code Coverage |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #477 +/- ##
==========================================
+ Coverage 97.27% 97.37% +0.09%
==========================================
Files 579 579
Lines 47188 47188
Branches 3076 6221 +3145
==========================================
+ Hits 45902 45948 +46
+ Misses 1286 1240 -46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Test Results 12 files 12 suites 10m 56s ⏱️ Results for commit 89d6018. |
Contributor
🔍 PR Validation ResultsVersion: `` ✅ Validation Steps
📊 ArtifactsDry-run artifacts have been uploaded and will be available for 7 days. This comment was automatically generated by the PR validation workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #413
Verification