feat: add support SELECT all columns from function result#2207
Merged
manticore-projects merged 1 commit intoJSQLParser:masterfrom Mar 26, 2025
Conversation
PostgreSQL supports composite type expansion using .*,
for example below query is valid in PostgreSQL:
SELECT (pg_stat_file('postgresql.conf')).*
Contributor
|
Beautifully executed! Well done and thank you much for your effort and contribution. |
Contributor
|
Greetings! Unfortunately, I found out that commit 30cf5d7 causes a huge performance deterioration: This toll is not acceptable for a rather exotic feature only and I am going to disable it. You are welcome to refactor your code and I will most happily accept it again once performance can be proved. Recommendations:
I am open for discussion of course. |
manticore-projects
added a commit
that referenced
this pull request
May 13, 2025
- optimise the `LOOKAHEAD`, avoid syntactic lookaheads - disable `FunctionAllColumns()` in `PrimaryExpression` related to #2207 Signed-off-by: Andreas Reichel <andreas@manticore-projects.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL supports composite type expansion using
.*, for example, below query is valid in PostgreSQL:More generic one is like below one in queries or sub-queries:
There might be multiple duplicated parentheses surround the function call, such as:
The PR is adding the support to parse/deparse this type of SQLs.