feature/fix: parsing inserts/updates/delete within CTEs

[nicky6s]

Problem
In Postgres it is valid syntax to have insert, update or delete statements appear within CTEs.

See here on https://www.postgresql.org/docs/current/sql-select.html

with_query_name [ ( column_name [, ...] ) ] AS [ [ NOT ] MATERIALIZED ] ( select | values | insert | update | delete )

e.g.

WITH inserted AS (
   INSERT INTO x (foo)
   SELECT bar FROM b
   RETURNING y
)
SELECT y
  FROM inserted;

The current version of the parser fails when faced with these statements as only ParenthesedSelects are allowed to appear within CTEs

Solution
Change the WithItem class so that...

• WithItem no longer extends ParenthesedSelect
• Instead WithItem has type T where T extends the new interface ParenthesedStatement
• ParenthesedSelect implements ParenthesedStatement
• New classes ParenthesedInsert + ParenthesedUpdate + ParenthesedDelete are also implementations ParenthesedStatement

Notes
I could definitely do with some feedback on the approach Ive taken here.

I've done my best to avoid impacting any existing functionality. The method getWithItemsList in various classes now returns a List<WithItem<?>> object rather than a List<WithItem> object. I think this should be the most "disruptive" thing I've included.

[manticore-projects]

Impressive contribution, thank you already for your time and effort!
Please give me a time to digest and appreciate everything properly. We will definitely merge this eventually!

[manticore-projects]

Clean, I really do like your work! Thank you again.
Please do me 2 favors though:

1. fix the Codacy exceptions
2. for the 2 failing Gradle performance tests, please reduce the number of loops from 10 to 6 (temporarily, there is a pending PR which fixes this properly)

[manticore-projects]

Please fix the formatting, then I can merge promptly.
Run './gradlew :spotlessApply' to fix these violations.

[manticore-projects]

Thank you again!

[nicky6s]

@manticore-projects I think Ive made the changes you've asked for...

fix the Codacy exceptions

85d114b

for the 2 failing Gradle performance tests, please reduce the number of loops from 10 to 6 (temporarily, there is a pending PR which fixes this properly)

1de2a39

Please fix the formatting

3f60913

However, Im still getting a Gradle test failure...

NestedBracketsPerformanceTest > testDeepFunctionParameters() FAILED
    net.sf.jsqlparser.JSQLParserException at NestedBracketsPerformanceTest.java:357
        Caused by: java.util.concurrent.TimeoutException at NestedBracketsPerformanceTest.java:357

3177 tests completed, 1 failed, 18 skipped

It's strange because when I run NestedBracketsPerformanceTest locally it all runs fine

[manticore-projects]

However, Im still getting a Gradle test failure...

No worries, I check/fix this from here.

[nicky6s]

@manticore-projects Thanks a lot for your help 🙇