You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note in the SQL files it says that the tests failed...but mvn test doesn't seem to show that at all? Not sure what I'm doing wrong, but wanted to make a PR anyway to see if the failures are legit?
First of all, thanks a lot for interest and contributing. Well appreciated.
On the details, we may need a few changes:
You have touched that "Special Oracle Tests" section, which is not advisable. This section is reserved for exotic Oracle features, and some of them are meant/known to fail -- and thus its silent.
Instead move your Tests into the normal test section and use the standard assertCanBeParsedAndDeparsed method. Do not add new failing tests or missing features without a solution please.
Your tests are BEGIN... END blocks and should be supported and working. What exactly is different about your examples please?
Please have a look at net/sf/jsqlparser/statement/BlockTest.java. There are Tests on Block Statements already and your additional Tests could go there.
Ok, great! I'll add them there. I didn't see the block tests, so thought this might be a real contribution. I'll move them to that file this week (hopefully with a fix)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
I didn't see any tests for anonymous statement blocks so figured I'd add them!
So I added three new tests for compound statements / anonymous blocks
Note in the SQL files it says that the tests failed...but
mvn testdoesn't seem to show that at all? Not sure what I'm doing wrong, but wanted to make a PR anyway to see if the failures are legit?