PR for #148: Improvements to github actions workflow

[liaochris]

No description provided.

[liaochris]

/run-actions-all --post

[github-actions]

Check Results (run details)

Check	Result	Time
SCons DAG	✅	0.030s
Newlines	✅	0.203s
EPS data	✅	0.024s
Build log	✅	0.028s

[liaochris]

/run-actions-issue

[liaochris]

/run-actions-all --post

[github-actions]

Check Results (run details)

Check	Result	Time
SCons DAG	✅	0.030s
Newlines	✅	0.106s
EPS data	✅	0.024s
Build log	✅	0.029s

[liaochris]

@zhizhongpu I added an issue subfolder after opening the pull, and I don't see the expected behavior (being unable to merge). I don't think the bypass list has been set up either?

I think the behavior I'm testing (adding an issue subfolder in the branch) is not what the test was design to account for but is something should still account for, as it's a scenario that could occur during the normal course of development.

[zhizhongpu]

@jmshapir I think we've reached a stage where it's efficient to set up the ruleset for branch protection

Please follow the steps below

a. In the repo setting for Template, add a new rule set of arbitrary name

b. Where I'm marking in the screenshots with a numeral, change the marked setting:

• 1: Set to "Active"
• 2: This is the bypass list. Please choose the appropriate set of users that includes @liaochris @zhizhongpu @jmshapir
• 3: Protection for main
• 4: Add a new requirement for status check "check-issue"
• 5: "Save changes"

Once these settings are applied, I expect to see the merge soft-blocked by the following interface here #148 (comment)

[jmshapir]

@zhizhongpu thanks. Below is the json for the rule I implemented. I did not include any other branch protections on this rule because we already have those in place via another rule. Let me know if any concerns.
no-issue-in-main.json

[zhizhongpu]

@zhizhongpu thanks. Below is the json for the rule I implemented. I did not include any other branch protections on this rule because we already have those in place via another rule. Let me know if any concerns. no-issue-in-main.json

thanks @jmshapir. I think this is

1. exactly what I did too. Here's a diff of our json files.
2. working as expected

@liaochris could you see if you see this interface?

If so, could you test the following two:

1. that removing the issue folder in a commit titled [run-actions-all] or [run-actions-issue] runs the check
2. that the check passes once the issue folder is removed

I expect these two tests to pass. I'm approving the PR so if you approve too, you could merge directly. If we need to test the comment trigger, we'd need that tested in a new PR.

[edit: perhaps wait for @jmshapir's review before merging]