[SDK-231] Add click handling tracking by lposen · Pull Request #799 · Iterable/react-native-sdk

lposen · 2026-01-11T23:23:47Z

🔹 JIRA Ticket(s) if any

SDK-231

✏️ Description

Added click handling and tracking

Testing

Run the setup
Login and then click on the "Embedded" tab
Click "Sync messages"
Click "Start session"
Click "Get messages"

On an individual message with valid click data, click "handle click"

The click should successfully be handled.

In the Xcode console, you should see a bunch of activity. This should include the following:

 💛 18:04:53.9160:0x600001807b40:OfflineRequestProcessor:addPendingTask(taskId:):466: adding pending task: D926EE25-F5DD-4312-8FCE-EC76EDAA9A9B
 💛 18:04:53.9160:0x600001852a40:IterableTaskRunner:execute(task:):186: Executing taskId: D926EE25-F5DD-4312-8FCE-EC76EDAA9A9B, name: embedded-messaging/events/click

Setup

cd into root and run yarn install
cd into example and run yarn install
cd into ios and run bundle exec pod install
open two separate terminals.
In Terminal 1
- run watchman watch-del-all
- run yarn start --reset-cache
In Terminal 2
- cd into ios
- run open ReactNativeSdkExample.xcworkspace
- Once Xcode opens the project, choose an emulator then click the play button to run it.

github-actions · 2026-01-11T23:24:20Z

Lines	Statements	Branches	Functions
	62.72% (392/625)	38.64% (97/251)	61.5% (139/226)

qltysh · 2026-01-11T23:24:31Z

Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

🚦 See full report on Qlty Cloud »

🛟 Help

Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.
Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.
File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)
- Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copilot

Pull request overview

This PR adds click tracking functionality for embedded messages in the iOS native layer. The implementation enables tracking user interactions with embedded messages, including button clicks with optional button identifiers and click URLs.

Changes:

Added trackEmbeddedClick method in Swift to handle embedded message click tracking with validation
Implemented TurboModule and legacy React Native bridge bindings in Objective-C++

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
ios/RNIterableAPI/ReactIterableAPI.swift	Added `trackEmbeddedClick` method that extracts message ID, looks up the cached message, validates parameters, and calls the native SDK tracking API
ios/RNIterableAPI/RNIterableAPI.mm	Added TurboModule bridge implementation to convert C++ types to NSDictionary and legacy architecture bridge export for React Native compatibility

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-12T20:07:27Z

ios/RNIterableAPI/ReactIterableAPI.swift

+    guard let clickedUrl = clickedUrl else {
+      ITBError("clickedUrl is required for trackEmbeddedClick")
+      return
+    }


The clickedUrl validation should be moved earlier in the function, before extracting the messageId and looking up the message in the cache. This would avoid unnecessary work when clickedUrl is null. Consider moving this check right after the ITBInfo() call to fail fast.

Copilot · 2026-01-12T20:07:28Z

ios/RNIterableAPI/RNIterableAPI.mm


 #if RCT_NEW_ARCH_ENABLED
  #import "RNIterableAPISpec.h"
+  #import <string>


The <string> header is imported but doesn't appear to be used in the visible code. If this import is not required by the generated RNIterableAPISpec.h header, consider removing it to keep the imports clean.

Suggested change

#import <string>

Ayyanchira

Approving with some possible suggestions

Ayyanchira · 2026-01-13T00:45:08Z

ios/RNIterableAPI/ReactIterableAPI.swift

+
+    // Find the message in the embedded manager's cache
+    let messages = IterableAPI.embeddedManager.getMessages()
+    guard let embeddedMessage = messages.first(where: { $0.metadata.messageId == messageId }) else {


Can this check for embedded message be avoided by using the method's input parameter? But it can make sense if EmbeddedMessage is not guaranteed to receive everytime.

Ayyanchira · 2026-01-13T00:45:41Z

ios/RNIterableAPI/ReactIterableAPI.swift


+  @objc(trackEmbeddedClick:buttonId:clickedUrl:)
+  public func trackEmbeddedClick(
+    message: NSDictionary, buttonId: String?, clickedUrl: String?


Can the message be of type EmbeddedMessage instead of generic string?

…se-impression-a' into loren/embedded/SDK-231-ios-add-click-handling-and-track

lposen added 2 commits January 11, 2026 14:56

feat: add trackEmbeddedClick method to ReactIterableAPI

6d1eb35

feat: use C++ type and convert to NSDictionary for Swift integration

6dfc081

lposen requested a review from Copilot January 12, 2026 20:03

lposen added the embedded Issues/PRs related to Embedded Messages label Jan 12, 2026

Copilot started reviewing on behalf of lposen January 12, 2026 20:03 View session

Copilot AI reviewed Jan 12, 2026

View reviewed changes

Ayyanchira approved these changes Jan 13, 2026

View reviewed changes

Merge branch 'loren/embedded/SDK-232-ios-add-start-impression-and-pau…

6cf7edb

…se-impression-a' into loren/embedded/SDK-231-ios-add-click-handling-and-track

Base automatically changed from loren/embedded/SDK-232-ios-add-start-impression-and-pause-impression-a to loren/embedded/master January 15, 2026 22:03

lposen merged commit 801570e into loren/embedded/master Jan 15, 2026
8 checks passed

lposen deleted the loren/embedded/SDK-231-ios-add-click-handling-and-track branch January 15, 2026 22:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SDK-231] Add click handling tracking#799

[SDK-231] Add click handling tracking#799
lposen merged 3 commits intoloren/embedded/masterfrom
loren/embedded/SDK-231-ios-add-click-handling-and-track

lposen commented Jan 11, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 11, 2026 •

edited

Loading

Uh oh!

qltysh bot commented Jan 11, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 12, 2026

Uh oh!

Copilot AI Jan 12, 2026

Uh oh!

Ayyanchira left a comment

Uh oh!

Ayyanchira Jan 13, 2026

Uh oh!

Ayyanchira Jan 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

lposen commented Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔹 JIRA Ticket(s) if any

✏️ Description

Testing

Setup

Uh oh!

github-actions bot commented Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qltysh bot commented Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Ayyanchira left a comment

Choose a reason for hiding this comment

Uh oh!

Ayyanchira Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Ayyanchira Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lposen commented Jan 11, 2026 •

edited

Loading

github-actions bot commented Jan 11, 2026 •

edited

Loading

qltysh bot commented Jan 11, 2026 •

edited

Loading