Skip to content

New journal operations#786

Merged
spirali merged 8 commits intomainfrom
prunning
Nov 19, 2024
Merged

New journal operations#786
spirali merged 8 commits intomainfrom
prunning

Conversation

@spirali
Copy link
Copy Markdown
Collaborator

@spirali spirali commented Nov 16, 2024

Adds:
hq journal flush
hq journal prune
hq start server --journal-flush-period=...

Among others, it solves: #785

Fixes: #785

@spirali spirali requested a review from Kobzol November 16, 2024 09:05
Copy link
Copy Markdown
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments.

Comment thread crates/hyperqueue/src/server/event/journal/stream.rs
Comment thread crates/hyperqueue/src/server/event/journal/stream.rs Outdated
Comment thread crates/hyperqueue/src/server/event/journal/stream.rs
Comment thread crates/hyperqueue/src/client/commands/journal/mod.rs
@Kobzol
Copy link
Copy Markdown
Member

Kobzol commented Nov 19, 2024

I don't understand the c38892a commit. You don't need Option, you can simply drop(writer) and then overwrite it a few lines below.

@spirali
Copy link
Copy Markdown
Collaborator Author

spirali commented Nov 19, 2024

I don't understand the c38892a commit. You don't need Option, you can simply drop(writer) and then overwrite it a few lines below.

You are right, I have realized it during the night and do not have time fix it yet :)

@spirali spirali merged commit 16a7861 into main Nov 19, 2024
@spirali spirali deleted the prunning branch November 19, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Journal size

2 participants