Conversation
oleksandr-pavlyk
approved these changes
Oct 12, 2023
Contributor
oleksandr-pavlyk
left a comment
oleksandr-pavlyk
left a comment
There was a problem hiding this comment.
LGTM. Similar change to this was already merged in dpctl: IntelPython/dpctl#1435 and main trunk build is clean.
oleksandr-pavlyk
force-pushed
the
fix/wheel_upload
branch
from
16c9e8e to
41d074d
Compare
github-actions bot
added a commit
that referenced
this pull request
Oct 12, 2023
Upload wheel to the same version cf7b9f4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wheels are uploaded to the version from wheels package that comes from versioner. That version is different for wheel and Conda and contains GitHub stash. That results into junk in Conda registry version list. PR simply uploads same wheel to the version of Conda package.