Use isort and add pre-commit workflow#143
Closed
ndgrigorian wants to merge 7 commits intoadd-pre-commitfrom
Closed
Use isort and add pre-commit workflow#143ndgrigorian wants to merge 7 commits intoadd-pre-commitfrom
isort and add pre-commit workflow#143ndgrigorian wants to merge 7 commits intoadd-pre-commitfrom
Conversation
ndgrigorian
requested review from
antonwolfy,
ekomarova,
vtavana and
xaleryb
as code owners
Also exclude vendored conv_template.py from black style checks
ndgrigorian
force-pushed
the
add-isort-pre-commit-workflow
branch
from
4a2dce8 to
0cf64f5
Compare
vtavana
force-pushed
the
add-pre-commit
branch
2 times, most recently
from
47513b5 to
5efbeff
Compare
Contributor
|
included in #142 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes in addition to adding pre-commit, adding isort and a workflow for pre-commit
Also fixes files which seemed to be failing black checks and adds black and isort to
pyproject.toml