Implementation of convolve#2205
Merged
AlexanderKalistratov merged 18 commits intomasterfrom Apr 1, 2025
Merged
Conversation
AlexanderKalistratov
requested review from
antonwolfy,
vlad-perevezentsev and
vtavana
as code owners
AlexanderKalistratov
force-pushed
the
convolve
branch
from
84ad9a8 to
6d8689f
Compare
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2205/index.html |
AlexanderKalistratov
force-pushed
the
convolve
branch
from
6d8689f to
c6dde99
Compare
AlexanderKalistratov
force-pushed
the
correlate_fft
branch
from
5f429be to
6eb94b2
Compare
AlexanderKalistratov
force-pushed
the
convolve
branch
from
c6dde99 to
b39e5c9
Compare
AlexanderKalistratov
force-pushed
the
convolve
branch
from
4168f27 to
3a03fdc
Compare
AlexanderKalistratov
force-pushed
the
convolve
branch
from
3a03fdc to
1c52d67
Compare
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Collaborator
Contributor
|
Array API standard conformance tests for dpnp=0.18.0dev0=py312he4f9c94_80 ran successfully. |
Collaborator
Author
|
@antonwolfy please review |
vtavana
reviewed
Mar 21, 2025
Co-authored-by: Vahid Tavanashad <120411540+vtavana@users.noreply.github.com>
Collaborator
Author
AlexanderKalistratov
left a comment
AlexanderKalistratov
left a comment
There was a problem hiding this comment.
@vtavana thanks for the review
please re-review.
vtavana
reviewed
Mar 26, 2025
antonwolfy
reviewed
Mar 27, 2025
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
antonwolfy
reviewed
Mar 28, 2025
antonwolfy
reviewed
Mar 29, 2025
AlexanderKalistratov
force-pushed
the
convolve
branch
from
4bb43c0 to
58e859a
Compare
antonwolfy
reviewed
Apr 1, 2025
antonwolfy
approved these changes
Apr 1, 2025
Contributor
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
Thank you @AlexanderKalistratov, LGTM
github-actions bot
added a commit
that referenced
this pull request
Apr 1, 2025
Add implementation of `dpnp.convolve`. Implementation is mostly based on already existing functionality developed for `dpnp.correlate` Similar to [scipy.signal.convolve](https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.convolve.html) `method` keyword is introduced, but unlike `scipy.signal.convolve` `dpnp.convolve` works only with 1-d arrays. - [x] Have you provided a meaningful PR description? - [x] Have you added a test, reproducer or referred to issue with a reproducer? - [x] Have you tested your changes locally for CPU and GPU devices? - [x] Have you made sure that new changes do not introduce compiler warnings? - [x] Have you checked performance impact of proposed changes? - [x] If this PR is a work in progress, are you filing the PR as a draft? --------- Co-authored-by: Vahid Tavanashad <120411540+vtavana@users.noreply.github.com> Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> f13e9a4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add implementation of
dpnp.convolve. Implementation is mostly based on already existing functionality developed fordpnp.correlateSimilar to scipy.signal.convolve
methodkeyword is introduced, but unlikescipy.signal.convolvedpnp.convolveworks only with 1-d arrays.