Merged
Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
requested review from
npolina4,
vlad-perevezentsev and
vtavana
as code owners
vtavana
reviewed
Nov 12, 2024
Co-authored-by: Vahid Tavanashad <120411540+vtavana@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Nov 13, 2024
* Implement dpnp.binary_repr * Add third party tests * Update links and add more examples with dpnp.binary_repr * Apply suggestions from code review Co-authored-by: Vahid Tavanashad <120411540+vtavana@users.noreply.github.com> --------- Co-authored-by: Vahid Tavanashad <120411540+vtavana@users.noreply.github.com> 7bfe0c8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR propose to add
dpnp.binary_reprfunction where the implementation leverages on numpy call.All required links from bit-wise functions towards
dpnp.binary_repris stated. While the examples are extended with use ofdpnp.binary_reprfunction.The testing is proposed to fully leverage third party tests scope for that functionality.