Add implementation of dpnp.gcd and dpnp.lcm functions#2091
Merged
antonwolfy merged 8 commits intomasterfrom Oct 9, 2024
Merged
Add implementation of dpnp.gcd and dpnp.lcm functions#2091antonwolfy merged 8 commits intomasterfrom
dpnp.gcd and dpnp.lcm functions#2091antonwolfy merged 8 commits intomasterfrom
Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
changed the title
dpnp.gcd and dpnp.lcm functions
antonwolfy
requested review from
npolina4,
vlad-perevezentsev and
vtavana
as code owners
vlad-perevezentsev
approved these changes
Oct 9, 2024
Contributor
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
There was a problem hiding this comment.
Looks good!
Thank you @antonwolfy
github-actions bot
added a commit
that referenced
this pull request
Oct 9, 2024
* Add gcd and lcm implementations to ufunc * Add gcd and lcm functions to mathematical interface * Add CFD tests * Add third party tests * Add more tests * Update description of input arrays c4677e9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR proposes to add implementation of
dpnp.gcdanddpnp.lcmfunctions.The new dedicated
_gcdand_lcmfunctions are added to_ufunc_implpybind11 extension.All the required tests are implemented to cover the new functions.