Implementation of dpnp.append and dpnp.asarray_chkfinite#2015
Merged
Implementation of dpnp.append and dpnp.asarray_chkfinite#2015
dpnp.append and dpnp.asarray_chkfinite#2015Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
vtavana
requested review from
antonwolfy,
npolina4 and
vlad-perevezentsev
as code owners
npolina4
reviewed
Aug 29, 2024
npolina4
approved these changes
Aug 29, 2024
github-actions bot
added a commit
that referenced
this pull request
Aug 29, 2024
* implement dpnp.append * implement dpnp.asarray_chkfinite * remove limitation for array creation functions * fix pre-commit * fix failed tests * add no copy test 838dbda
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR,
dpnp.appendanddpnp.asarray_chk_finiteare implementedorderkeyword ineye,ones,zeros,full, andemptyfunctions in NumPy only supports"C"and"F", anddpnpdoes not have any limitation in this regard. Docstring of these functions indpnpis updated to reflect this fact.