Add implementation of dpnp.float_power#1957
Merged
antonwolfy merged 8 commits intomasterfrom Aug 7, 2024
Merged
Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
vlad-perevezentsev
approved these changes
Aug 7, 2024
Contributor
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
There was a problem hiding this comment.
LGTM!
Thank you @antonwolfy
github-actions bot
added a commit
that referenced
this pull request
Aug 7, 2024
* Add implementation of dpnp.float_power() * Updated third party tests * Added more tests to cover different scenarios * Mute back test for dpnp.floor_divide * Update docstring with another way to state NaN value * Address comment to update tests cfaae8c
antonwolfy
added a commit
that referenced
this pull request
Jan 11, 2025
The PR proposes to implement fixes/improvements into the public CI: - run `pre-commit` and `building docs` workflows on Ubuntu-22.04 (`ubuntu-latest` now refers to Ubuntu-24.04 where the workflows fail as for now) - use `fail-fast: false` rather than `continue-on-error: false` in workflow with night tests run (some jobs in strategy matrix may fail due to mamba/conda issues) _Note, the workflow will be reported as failed if any job fails._ - trigger rerun tests step on failure of `run_tests` step only in night tests workflow - trigger resetup minoconda step on failure in night tests and conda package workflows - build name of running job based on python and OS from strategy matrix - disable night tests workflow to be run in forked repositories Also the PR includes adaptation to the recent interface changes in dpctl implemented in [gh-1957](IntelPython/dpctl#1957).
github-actions bot
added a commit
that referenced
this pull request
Jan 11, 2025
The PR proposes to implement fixes/improvements into the public CI: - run `pre-commit` and `building docs` workflows on Ubuntu-22.04 (`ubuntu-latest` now refers to Ubuntu-24.04 where the workflows fail as for now) - use `fail-fast: false` rather than `continue-on-error: false` in workflow with night tests run (some jobs in strategy matrix may fail due to mamba/conda issues) _Note, the workflow will be reported as failed if any job fails._ - trigger rerun tests step on failure of `run_tests` step only in night tests workflow - trigger resetup minoconda step on failure in night tests and conda package workflows - build name of running job based on python and OS from strategy matrix - disable night tests workflow to be run in forked repositories Also the PR includes adaptation to the recent interface changes in dpctl implemented in [gh-1957](IntelPython/dpctl#1957). 303a203
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR adds implementation of
dpnp.float_powerfunctions.There is no dedicated function added to
_ufunc_implextension but reused_powfunctions from dpctl.tensor and from VM extension. The only function which was required to be implemented is_float_power_result_typeto redefine a table with supported data types.Unlike numpy,
dpnp.float_powerhas to support also float32 and complex64 data types. It is done to work on a device without fp64 support,Third party tests are updated, affected tests are unmuted, new ones are added to cover more use cases.