Update dpnp.linalg.inv() function#1665
Merged
vlad-perevezentsev merged 17 commits intomasterfrom Jan 29, 2024
Merged
Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
reviewed
Jan 23, 2024
antonwolfy
reviewed
Jan 25, 2024
antonwolfy
approved these changes
Jan 29, 2024
Contributor
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
LGTM! Thank you @vlad-perevezentsev
github-actions bot
added a commit
to antonwolfy/dpnp
that referenced
this pull request
Jan 29, 2024
* Impl dpnp.linalg.inv for 2d array * Remove an old impl of dpnp_inv * Add batch implementation of dpnp.linalg.inv func * Add cupy tests for dpnp.linalg.inf * Add dpnp tests for dpnp.linalg.inv * Add check_lapack_dev_info func * Add dev_info size check for getri_batch and getrf_batch * Add size check dev_info and error_matrices_ids * Remove dpnp_inv_ext_c * Rename check_lapack_dev_info to _check_lapack_dev_info * Skip test_inv in TestInvInvalid --------- Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 7a56304
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR update
dpnp.linalg.inv()function to calculate the (multiplicative) inverse matrix usingoneapi::mkl::lapack::gesvfor 2d input matrix andoneapi::mkl::lapack::getrf_batchandoneapi::mkl::lapack::getri_batchfor input array dimensions > 2.The implementation is written as a pybind11 extension above required LAPACK functions.
The changes are related to support of all types and support of function arguments as full_matrices and compute_uv