update out keyword for elementwise functions#1656
Merged
Conversation
update out keyword elementwise
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
reviewed
Jan 17, 2024
antonwolfy
approved these changes
Jan 17, 2024
Contributor
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
@vtavana. thank you for catching and resolving that!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, a bug related to
outkeyword in elementwise functions is fixed.In the current implementation of the elementwise functions, the output of the function and the output coming from
outkeyword are two different copies of the same data. The code is modified to make the output of the function a view of the output corresponding to theoutkeyword.