Implement of dpnp.linalg.slogdet()#1607
Merged
antonwolfy merged 66 commits intomasterfrom Jan 12, 2024
Merged
Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html |
… and add explanatory comments
antonwolfy
reviewed
Jan 9, 2024
antonwolfy
approved these changes
Jan 10, 2024
Contributor
antonwolfy
left a comment
There was a problem hiding this comment.
Thank you @vlad-perevezentsev LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
adds a function
dpnp.linalg.slogdet()to getsignandlogarithmof the determinant of an input array and a private functiondpnp.linalg._lu_factor()to compute the LU factorization of a generaln x ninput matrix using
oneapi::mkl::lapack::getrfandoneapi::mkl::lapack::getrf_batch.The implementation is written as an extension of pybind11 over the necessary LAPACK functions.
updates the implementation of the
dpnp.linalg.det()function usingdpnp.linalg.slogdet()adds support the complex data type for
dpnp.diagonal()function