Permit `"same_kind"` casting for `usm_ndarray` element-wise in-place operators by ndgrigorian · Pull Request #1827 · IntelPython/dpctl

ndgrigorian · 2024-09-10T02:57:53Z

This pull request proposes a new implementation for in-place element-wise operators which permits casting equivalent to "same_kind"

This allows such operations as

In [1]: import dpctl.tensor as dpt, dpctl, numpy as np

In [2]: x = dpt.ones((10, 10), dtype="i4")

In [3]: y = dpt.ones((10, 10), dtype="i8")

In [4]: x += y

In [5]: x
Out[5]:
usm_ndarray([[2, 2, 2, 2, 2, 2, 2, 2, 2, 2],
             [2, 2, 2, 2, 2, 2, 2, 2, 2, 2],
             [2, 2, 2, 2, 2, 2, 2, 2, 2, 2],
             [2, 2, 2, 2, 2, 2, 2, 2, 2, 2],
             [2, 2, 2, 2, 2, 2, 2, 2, 2, 2],
             [2, 2, 2, 2, 2, 2, 2, 2, 2, 2],
             [2, 2, 2, 2, 2, 2, 2, 2, 2, 2],
             [2, 2, 2, 2, 2, 2, 2, 2, 2, 2],
             [2, 2, 2, 2, 2, 2, 2, 2, 2, 2],
             [2, 2, 2, 2, 2, 2, 2, 2, 2, 2]], dtype=int32)

This PR maintains the inclusion of (conditionally used) in-place kernels in element-wise operators when dpt.bin_op(x, y, out=x) for some bin_op which has an in-place implementation.

Resolves #1757

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
Have you added documentation for your changes, if necessary?
Have you added your changes to the changelog?
If this PR is a work in progress, are you opening the PR as a draft?

github-actions · 2024-09-10T03:32:17Z

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

github-actions · 2024-09-10T03:37:25Z

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_9 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

github-actions · 2024-09-10T03:41:28Z

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_9 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

github-actions · 2024-09-10T03:45:26Z

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_9 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

github-actions · 2024-09-10T07:28:44Z

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_10 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

coveralls · 2024-09-10T07:31:09Z

coverage: 87.907% (+0.01%) from 87.893%
when pulling 7599b37 on in-place-element-wise-func-casting
into cd7d41c on master.

This method permits casting behavior equivalent to `"same_kind"` when using in-place operators by introducing the `_inplace_op` method Expands this to `__imatmul__` as well through use of the already-implemented `dtype` keyword

…ame_kind"` casting

Raises `ValueError` otherwise

…re both inputs are broadcast to a new shape

github-actions · 2024-09-10T18:12:53Z

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_13 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

github-actions · 2024-09-10T18:33:18Z

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_14 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

Also clean up and make some tests for in-place operators more efficient

github-actions · 2024-09-10T22:50:57Z

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_16 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

ndgrigorian · 2024-09-10T23:32:09Z

@oleksandr-pavlyk
Tests are adjusted for the new behavior, this is RFR

dpctl/tensor/_elementwise_common.py

github-actions · 2024-09-11T15:46:19Z

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_17 ran successfully.
Passed: 893
Failed: 2
Skipped: 119

dpctl/tensor/_elementwise_common.py

oleksandr-pavlyk

Overall this change looks good to me, modulo a nit! Thank you @ndgrigorian

github-actions · 2024-09-11T19:16:40Z

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_18 ran successfully.
Passed: 893
Failed: 2
Skipped: 119

vtavana · 2024-09-11T19:20:53Z

I ran dpnp tests with this branch and they pass.

CHANGELOG.md

…ace_dtype_matrix`

Co-authored-by: Oleksandr Pavlyk <oleksandr.pavlyk@intel.com>

github-actions · 2024-09-11T20:01:06Z

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_19 ran successfully.
Passed: 893
Failed: 2
Skipped: 119

github-actions · 2024-09-11T20:18:05Z

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_20 ran successfully.
Passed: 893
Failed: 2
Skipped: 119

github-actions · 2024-09-11T20:28:36Z

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_21 ran successfully.
Passed: 893
Failed: 2
Skipped: 119

oleksandr-pavlyk

LGTM! Thank you @ndgrigorian

Backport gh-1827

The PR proposes to permit `"same_kind"` casting for element-wise in-place operators. The implementation leverages on dpctl changes added in scope of [PR#1827](IntelPython/dpctl#1827). It also adds callbacks to support in-place bit-wise operators (leverages on dpctl changes from [RR#1447](IntelPython/dpctl#1447)). The PR removes a temporary workaround from `dpnp.wrap` which depends on the implemented changes.

The PR proposes to permit `"same_kind"` casting for element-wise in-place operators. The implementation leverages on dpctl changes added in scope of [PR#1827](IntelPython/dpctl#1827). It also adds callbacks to support in-place bit-wise operators (leverages on dpctl changes from [RR#1447](IntelPython/dpctl#1447)). The PR removes a temporary workaround from `dpnp.wrap` which depends on the implemented changes. 3d02b6b

ndgrigorian force-pushed the in-place-element-wise-func-casting branch 2 times, most recently from f81119f to 13fde04 Compare September 10, 2024 03:07

ndgrigorian added 2 commits September 10, 2024 10:31

Implements BinaryElementwiseFunc._inplace_op method

bab3571

This method permits casting behavior equivalent to `"same_kind"` when using in-place operators by introducing the `_inplace_op` method Expands this to `__imatmul__` as well through use of the already-implemented `dtype` keyword

Adjusts tests for in-place element-wise operations to account for `"s…

79208c8

…ame_kind"` casting

ndgrigorian force-pushed the in-place-element-wise-func-casting branch from f1ac695 to 79208c8 Compare September 10, 2024 17:32

ndgrigorian added 2 commits September 10, 2024 10:52

BinaryElementwiseFunc._inplace_op now checks if a kernel is available

f13c02d

Raises `ValueError` otherwise

Adds message to ValueError for cast of binary in-place operator whe…

d7fba40

…re both inputs are broadcast to a new shape

Add more tests for element-wise in-place operators

7f59819

Also clean up and make some tests for in-place operators more efficient

ndgrigorian marked this pull request as ready for review September 10, 2024 23:31

ndgrigorian requested a review from oleksandr-pavlyk as a code owner September 10, 2024 23:31

ndgrigorian requested review from npolina4 and vtavana September 10, 2024 23:32

oleksandr-pavlyk reviewed Sep 11, 2024

View reviewed changes

dpctl/tensor/_elementwise_common.py Show resolved Hide resolved

Change per PR review to exception in UnaryElementwiseFunc

9529f0a

oleksandr-pavlyk reviewed Sep 11, 2024

View reviewed changes

dpctl/tensor/_elementwise_common.py Outdated Show resolved Hide resolved

oleksandr-pavlyk reviewed Sep 11, 2024

View reviewed changes

Change per PR review by @oleksandr-pavlyk

54dd6b6

Add changes to in-place element-wise operators to changelog

0297fbe

oleksandr-pavlyk reviewed Sep 11, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

ndgrigorian and others added 2 commits September 11, 2024 12:38

Add comments explaining logic behind various stages of `test_add_inpl…

7ba5c31

…ace_dtype_matrix`

Fix typo in changelog entry

7599b37

Co-authored-by: Oleksandr Pavlyk <oleksandr.pavlyk@intel.com>

oleksandr-pavlyk approved these changes Sep 11, 2024

View reviewed changes

ndgrigorian merged commit 8b25773 into master Sep 11, 2024

ndgrigorian deleted the in-place-element-wise-func-casting branch September 11, 2024 21:51

oleksandr-pavlyk mentioned this pull request Sep 12, 2024

Backport gh-1827 #1830

Merged

8 tasks

oleksandr-pavlyk added a commit that referenced this pull request Sep 12, 2024

Add entry for gh-1827 to changelog of 0.18 release

406af46

oleksandr-pavlyk added a commit that referenced this pull request Sep 12, 2024

Merge pull request #1830 from IntelPython/backport-gh-1827

19331c0

Backport gh-1827

oleksandr-pavlyk added a commit that referenced this pull request Sep 12, 2024

Add entry for gh-1827 to changelog of 0.18 release

5f24f70

oleksandr-pavlyk mentioned this pull request Sep 12, 2024

[MAINT] Update changelog after backport gh 1830 #1832

Merged

8 tasks

antonwolfy mentioned this pull request Nov 13, 2024

Permit "same_kind" casting for element-wise in-place operators IntelPython/dpnp#2170

Merged

6 tasks

Conversation

ndgrigorian commented Sep 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 10, 2024

Uh oh!

github-actions bot commented Sep 10, 2024

Uh oh!

github-actions bot commented Sep 10, 2024

Uh oh!

github-actions bot commented Sep 10, 2024

Uh oh!

coveralls commented Sep 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 10, 2024

Uh oh!

github-actions bot commented Sep 10, 2024

Uh oh!

github-actions bot commented Sep 10, 2024

Uh oh!

ndgrigorian commented Sep 10, 2024

Uh oh!

Uh oh!

github-actions bot commented Sep 11, 2024

Uh oh!

Uh oh!

oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 11, 2024

Uh oh!

vtavana commented Sep 11, 2024

Uh oh!

Uh oh!

github-actions bot commented Sep 11, 2024

Uh oh!

github-actions bot commented Sep 11, 2024

Uh oh!

github-actions bot commented Sep 11, 2024

Uh oh!

oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ndgrigorian commented Sep 10, 2024 •

edited

Loading

github-actions bot commented Sep 10, 2024 •

edited

Loading

coveralls commented Sep 10, 2024 •

edited

Loading