Implements dpctl.tensor.nextafter per array API#1730
Implements dpctl.tensor.nextafter per array API#1730oleksandr-pavlyk merged 6 commits intomasterfrom
dpctl.tensor.nextafter per array API#1730Conversation
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310h15de555_105 ran successfully. |
The basic test also to include nextafter(arr, 0), nextafter(arr, inf), nextafter(arr, -inf)
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310h15de555_113 ran successfully. |
oleksandr-pavlyk
left a comment
There was a problem hiding this comment.
LGTM! Thank you @ndgrigorian
I did push changes to extend test file.
|
BTW, |
|
Reported as OFNAAO-302. Will add skipping this test for "float16" on CUDA devices for now. |
Implementation of CUDA backend for DPC++ has a known issue where sycl::nextafter for sycl::half type does not comply with C++ stipulation that nextafter(from_, to_) must return to_ if from_ is equal to to_.
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310h15de555_116 ran successfully. |
antonwolfy
left a comment
There was a problem hiding this comment.
I've reused it in dpnp-1938 and it works fine. Thank you!
This PR implements the
nextafterfunction coming to the next version of the array API specification