Addresses gh-1360 with documentation#1653
Merged
oleksandr-pavlyk merged 2 commits intomasterfrom Apr 23, 2024
Merged
Conversation
Document race condition in put when indices array contain duplicated. Provide an example of resolving race condition for 1-d ``x``, ``indices``, and ``vals``.
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Collaborator
|
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_302 ran successfully. |
ndgrigorian
reviewed
Apr 23, 2024
Also, improved wording in the added note.
ndgrigorian
approved these changes
Apr 23, 2024
Collaborator
ndgrigorian
left a comment
There was a problem hiding this comment.
This LGTM, good to have this example!
|
Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_309 ran successfully. |
This was referenced Apr 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document race condition in put when indices array contain duplicated. Provide an example of resolving race condition for 1-d
x,indices, andvals.This PR supersedes gh-1384, since support for
unique_onlycan not be efficiently support for higher rank arrays withaxesspecified.