clip permits None for min and max#1505
Conversation
When provided a non-usm_ndarray-input to copy, copy would return the error instead of raising it
Also resolves gh-1489
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1505/index.html |
|
Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_28 ran successfully. |
|
Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_29 ran successfully. |
|
Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_32 ran successfully. |
oleksandr-pavlyk
left a comment
There was a problem hiding this comment.
LGTM! Nice to see coverage climb up like this. Thank you @ndgrigorian
antonwolfy
left a comment
There was a problem hiding this comment.
Works as expected with DPNP tests now. Thank you @ndgrigorian !
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
This pull request adjusts dpctl.tensor.clip to permit
minandmaxto beNonesimultaneously, resulting in effectively a no-op.In addition, makes a small adjustment to dpctl.tensor.copy, which would return a
TypeErrorinstead of raising it, and resolves #1489 by fixing two typos in_resolve_one_strong_one_weak_types