Merged
Conversation
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1504/index.html |
Collaborator
|
Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_26 ran successfully. |
npolina4
approved these changes
Jan 24, 2024
Contributor
npolina4
left a comment
There was a problem hiding this comment.
LGTM! Thank you @oleksandr-pavlyk
ndgrigorian
approved these changes
Jan 25, 2024
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-1503
In code copying usm_ndarray into usm_ndarray, when broadcasting
rhsto the common shape usingusm_ndarrayconstructor,offsetparameter was not being set, causing incorrect behavior reported gh-1503.This PR specifies the
offsetparameter, and adds test based on reproducing example of said issue.