Replaced few TypeError with ValueError in _elementwise_common#1496
Conversation
Used ValueError instead of TypeError per Python guidelines. Inappriate uses were pointed out by @vtavana
|
This change was prompted per discussion in #1490 |
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1496/index.html |
vtavana
left a comment
There was a problem hiding this comment.
Thank you, @oleksandr-pavlyk!
|
Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_7 ran successfully. |
9d172b7 to
a2ec2f2
Compare
|
Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_8 ran successfully. |
|
Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_9 ran successfully. |
|
Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_9 ran successfully. |
ndgrigorian
left a comment
There was a problem hiding this comment.
Tests now pass so LGTM! Thanks for this clean up @oleksandr-pavlyk
Other incorrect TypeErrors seem to exist in the project but those can be addressed in separate PRs.
Used
ValueErrorinstead ofTypeErrorper Python guidelines.Inappropriate uses were pointed out by @vtavana (Thank you)