Skip to content

Remove marks broken_complex from all tests#1475

Merged
oleksandr-pavlyk merged 4 commits intomasterfrom
take-down-broken-complex-marks
Dec 13, 2023
Merged

Remove marks broken_complex from all tests#1475
oleksandr-pavlyk merged 4 commits intomasterfrom
take-down-broken-complex-marks

Conversation

@oleksandr-pavlyk
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Nov 24, 2023

After transition to sycl::ext::oneapi::experimental namespace functions for complex types in gh-1411, all tests pass.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

github-actions bot commented Nov 24, 2023

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1475/index.html

@coveralls
Copy link
Collaborator

coveralls commented Nov 24, 2023 •
edited
Loading

Coverage Status

coverage: 85.998%. remained the same
when pulling 3bcc7df on take-down-broken-complex-marks
into 46583b8 on master.

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the take-down-broken-complex-marks branch from 95b55f9 to 3689e84 Compare November 27, 2023 15:46
@github-actions
Copy link

github-actions bot commented Nov 27, 2023

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_19 ran successfully.
Passed: 876
Failed: 55
Skipped: 59

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 27, 2023

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_19 ran successfully.
Passed: 876
Failed: 55
Skipped: 59

@github-actions
Copy link

github-actions bot commented Nov 29, 2023

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_20 ran successfully.
Passed: 875
Failed: 56
Skipped: 59

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the take-down-broken-complex-marks branch from df6e288 to 3c1b5c9 Compare November 29, 2023 23:01
@github-actions
Copy link

github-actions bot commented Nov 29, 2023

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_20 ran successfully.
Passed: 875
Failed: 56
Skipped: 59

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the take-down-broken-complex-marks branch from 3c1b5c9 to 9180ecf Compare December 5, 2023 19:24
@github-actions
Copy link

github-actions bot commented Dec 5, 2023

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_23 ran successfully.
Passed: 876
Failed: 55
Skipped: 59

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the take-down-broken-complex-marks branch from 9180ecf to b1a4084 Compare December 9, 2023 04:38
@github-actions
Copy link

github-actions bot commented Dec 9, 2023

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_33 ran successfully.
Passed: 876
Failed: 56
Skipped: 59

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the take-down-broken-complex-marks branch from b1a4084 to a8ebd37 Compare December 11, 2023 22:29
@oleksandr-pavlyk
Remove marks broken_complex from all tests
3828d86 
After transition to oneapi::experimental namespace functions
for complex types in gh-1411, all tests pass.
@oleksandr-pavlyk
Do not run special case tests for complex values on Windows
f2dfb81 
Since NumPy's output is not the same on Linux/Windows, tests fail
on Windows, so they are skipped. Instead, f(conj(arg)) = conj(f(arg))
is tested on all platforms for those special values.
@oleksandr-pavlyk
Make test failure for test_sqrt_fp_complex_special_case more informative
d1ff841
@oleksandr-pavlyk
Do not fail test_sqrt_complex_fp_special_values on failure, but skip …
3bcc7df 
…the test with message
@oleksandr-pavlyk oleksandr-pavlyk force-pushed the take-down-broken-complex-marks branch from a8ebd37 to 3bcc7df Compare December 12, 2023 03:50
@github-actions
Copy link

github-actions bot commented Dec 12, 2023

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_35 ran successfully.
Passed: 879
Failed: 53
Skipped: 59

@oleksandr-pavlyk
Copy link
Contributor Author

oleksandr-pavlyk commented Dec 13, 2023

@ndgrigorian This PR removes uses of @broken_complex test marker.

@ndgrigorian
Copy link
Collaborator

ndgrigorian commented Dec 13, 2023

@ndgrigorian This PR removes uses of @broken_complex test marker.

It looks good overall, but I assume the sqrt test is still failing on Windows (and therefore being skipped).
But perhaps that issue is best deferred to a separate PR. I'll take a second look before I approve.

@oleksandr-pavlyk
Copy link
Contributor Author

oleksandr-pavlyk commented Dec 13, 2023

@ndgrigorian This PR removes uses of @broken_complex test marker.

It looks good overall, but I assume the sqrt test is still failing on Windows (and therefore being skipped). But perhaps that issue is best deferred to a separate PR. I'll take a second look before I approve.

The test_sqrt_complex_fp_special_cases is passing using oneAPI DPC++ compiler on all platforms. It is failing using SYCLOS compiler:

dpctl/tests/elementwise/test_sqrt.py::test_sqrt_complex_fp_special_values[c8] PASSED [ 94%]
dpctl/tests/elementwise/test_sqrt.py::test_sqrt_complex_fp_special_values[c16] SKIPPED [ 94%]

@oleksandr-pavlyk oleksandr-pavlyk merged commit bb5ff39 into master Dec 13, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the take-down-broken-complex-marks branch December 13, 2023 18:51
@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request Jan 26, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oleksandr-pavlyk @coveralls @ndgrigorian