Improves performance of search reductions for small numbers of elements#1464
Merged
ndgrigorian merged 2 commits intooptimize-small-size-tree-reductionfrom Nov 3, 2023
Merged
Conversation
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1464/index.html |
|
Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_79 ran successfully. |
constexpr branch logic accounted for floating point types but not sycl::half, which meant NaNs were not propagating for float16 data
|
Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_81 ran successfully. |
ndgrigorian
force-pushed
the
sequential-search-kernels
branch
from
acd93ae to
119d43d
Compare
oleksandr-pavlyk
approved these changes
Nov 3, 2023
Contributor
oleksandr-pavlyk
left a comment
oleksandr-pavlyk
left a comment
There was a problem hiding this comment.
Looks great @ndgrigorian , thank you!
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_83 ran successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds
SequentialSearchReductionfunctor to improveargmaxandargminfor small arrays.