Use partition_type_property descriptor in DPCTLDevice_GetParentDevice#1452
Merged
oleksandr-pavlyk merged 1 commit intomasterfrom Oct 24, 2023
Merged
Use partition_type_property descriptor in DPCTLDevice_GetParentDevice#1452oleksandr-pavlyk merged 1 commit intomasterfrom
oleksandr-pavlyk merged 1 commit intomasterfrom
Conversation
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1452/index.html |
|
Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_44 ran successfully. |
This allows to test that the device is an unpartition device without raising and handling the C++ exception. If info::device::partition_type_property is info::partition_property::no_partition then retrieving the parent_device descriptor will throw.
oleksandr-pavlyk
force-pushed
the
improve-exception-parent-device
branch
from
006843e to
4ac53fd
Compare
Collaborator
|
Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_46 ran successfully. |
ndgrigorian
approved these changes
Oct 23, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
partition_type_propertydescriptor inDPCTLDevice_GetParentDevice.This allows to test that the device is an unpartitioned device without raising and handling the C++ exception.
If
info::device::partition_type_propertyisinfo::partition_property::no_partitionthen retrievingthe
parent_devicedescriptor will throw.This change reduces the clutter of expected [ERR] messages in
DPCTL_VERBOSITY=errormode.