Dedicated kernels for in-place dpt.divide and dpt.floor_divide#1431
Merged
ndgrigorian merged 3 commits intomasterfrom Oct 11, 2023
Merged
Dedicated kernels for in-place dpt.divide and dpt.floor_divide#1431ndgrigorian merged 3 commits intomasterfrom
dpt.divide and dpt.floor_divide#1431ndgrigorian merged 3 commits intomasterfrom
Conversation
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1431/index.html |
Collaborator
|
Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_8 ran successfully. |
dpctl/tensor/libtensor/include/kernels/elementwise_functions/true_divide.hpp
Show resolved
Hide resolved
dpctl/tensor/libtensor/include/kernels/elementwise_functions/true_divide.hpp
Show resolved
Hide resolved
Includes floor division and true division
Checks that the result type is either the same as the third template parameter, or none Adds a comment to TrueDivideInplaceOutputType
ndgrigorian
force-pushed
the
inplace-division-kernels
branch
from
3ed1d66 to
237b2d0
Compare
|
Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_33 ran successfully. |
oleksandr-pavlyk
approved these changes
Oct 11, 2023
Contributor
oleksandr-pavlyk
left a comment
oleksandr-pavlyk
left a comment
There was a problem hiding this comment.
Thank you @ndgrigorian for implementing this!
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements kernels for in-place division and floor division, i.e.,
dpt.divide(x, y, out=x)anddpt.floor_divide(x, y, out=x).This avoids allocating an additional buffer for the output and copying back to the first operand.