Check in of generic reduction templates and some reductions by ndgrigorian · Pull Request #1399 · IntelPython/dpctl

ndgrigorian · 2023-09-11T20:59:35Z

This pull request implements the necessary meta-programming utilities for reductions with arbitrary binary operators, templates for generic reductions, as well as the new functions dpctl.tensor.max, dpctl.tensor.min, dpctl.tensor.argmax, and dpctl.tensor.argmin.

These meta-programming utilities, such as Identity, make it possible to define unique aspects of a reduction such that it may be passed to a generic functor for computation.

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
If this PR is a work in progress, are you opening the PR as a draft?

github-actions · 2023-09-11T21:38:10Z

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1399/index.html

coveralls · 2023-09-11T22:02:30Z

coverage: 85.879% (+0.1%) from 85.777% when pulling 04ec23b on feature/reductions-custom-ops into caa0939 on master.

github-actions · 2023-09-11T22:21:09Z

Array API standard conformance tests for dpctl=0.14.6dev5=py310ha25a700_3 ran successfully.
Passed: 921
Failed: 79
Skipped: 119

github-actions · 2023-09-11T22:31:50Z

Array API standard conformance tests for dpctl=0.14.6dev5=py310ha25a700_3 ran successfully.
Passed: 922
Failed: 78
Skipped: 119

github-actions · 2023-09-14T20:18:37Z

Array API standard conformance tests for dpctl=0.14.6dev5=py310ha25a700_6 ran successfully.
Passed: 922
Failed: 78
Skipped: 119

github-actions · 2023-09-15T00:08:47Z

Array API standard conformance tests for dpctl=0.14.6dev5=py310ha25a700_7 ran successfully.
Passed: 921
Failed: 79
Skipped: 119

github-actions · 2023-09-15T02:07:14Z

Array API standard conformance tests for dpctl=0.14.6dev5=py310ha25a700_8 ran successfully.
Passed: 924
Failed: 76
Skipped: 119

github-actions · 2023-09-15T08:30:38Z

Array API standard conformance tests for dpctl=0.14.6dev5=py310ha25a700_9 ran successfully.
Passed: 924
Failed: 76
Skipped: 119

github-actions · 2023-09-15T08:51:06Z

Array API standard conformance tests for dpctl=0.14.6dev5=py310ha25a700_9 ran successfully.
Passed: 924
Failed: 76
Skipped: 119

github-actions · 2023-09-19T02:46:36Z

Array API standard conformance tests for dpctl=0.15.0rc1=py310ha25a700_9 ran successfully.
Passed: 929
Failed: 71
Skipped: 119

github-actions · 2023-09-19T07:20:22Z

Array API standard conformance tests for dpctl=0.15.0rc1=py310ha25a700_10 ran successfully.
Passed: 930
Failed: 70
Skipped: 119

github-actions · 2023-09-19T21:43:32Z

Array API standard conformance tests for dpctl=0.15.0rc1=py310ha25a700_11 ran successfully.
Passed: 930
Failed: 70
Skipped: 119

github-actions · 2023-09-22T05:32:06Z

Array API standard conformance tests for dpctl=0.15.0rc2=py310ha25a700_11 ran successfully.
Passed: 930
Failed: 70
Skipped: 119

github-actions · 2023-09-27T06:09:36Z

Array API standard conformance tests for dpctl=0.15.0rc3=py310ha25a700_13 ran successfully.
Passed: 930
Failed: 70
Skipped: 119

github-actions · 2023-09-27T06:41:57Z

Array API standard conformance tests for dpctl=0.15.0rc3=py310ha25a700_13 ran successfully.
Passed: 930
Failed: 70
Skipped: 119

github-actions · 2023-09-27T18:25:34Z

Array API standard conformance tests for dpctl=0.15.0rc3=py310ha25a700_15 ran successfully.
Passed: 927
Failed: 73
Skipped: 119

github-actions · 2023-09-27T18:35:48Z

Array API standard conformance tests for dpctl=0.15.0rc3=py310ha25a700_15 ran successfully.
Passed: 927
Failed: 73
Skipped: 119

github-actions · 2023-09-27T19:01:06Z

Array API standard conformance tests for dpctl=0.15.0rc3=py310ha25a700_15 ran successfully.
Passed: 930
Failed: 70
Skipped: 119

github-actions · 2023-09-28T01:56:30Z

Array API standard conformance tests for dpctl=0.15.0=py310ha25a700_19 ran successfully.
Passed: 930
Failed: 70
Skipped: 119

github-actions · 2023-09-28T21:56:22Z

Array API standard conformance tests for dpctl=0.15.0=py310ha25a700_22 ran successfully.
Passed: 930
Failed: 70
Skipped: 119

Adds a test for this behavior Fixed a typo in argmin and argmax causing shared local memory variant to be used for more types than expected

- comparison and search reductions will throw an error in this case - slips in change to align sum signature with array API spec

Removed unnecessary copies in custom_reduce_over_group Sequential reduction now casts before calling operator (makes behavior explicit rather than implicit)

Also removed unused `_usm_types` in `test_tensor_sum`

github-actions · 2023-09-29T21:17:35Z

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_19 ran successfully.
Passed: 930
Failed: 70
Skipped: 119

github-actions · 2023-09-29T22:07:42Z

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_19 ran successfully.
Passed: 930
Failed: 70
Skipped: 119

dpctl/tensor/libtensor/include/utils/sycl_utils.hpp

These were unused by dpctl

github-actions · 2023-10-01T00:05:37Z

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_20 ran successfully.
Passed: 930
Failed: 70
Skipped: 119

Implementation of Identity trait should call sycl::known_identity if trait sycl::has_known_identity is a true_type. Added IsMultiplies, and identity value for it, since sycl::known_identity for multiplies is only defined for real-valued types.

…icable Passing these function pointers around allows to turn atomic off altogether if desired. Use custom trait to check if reduce_over_groups can be used. This allows to work-around bug, or switch to custom code for reduction over group if desired. Such custom trait type works around issue with incorrect result returned from sycl::reduce_over_group for sycl::multiplies operator for 64-bit integral types.

Also tweaked docstring for sum.

Small tweaks to sum, min, and max docstrings

Implement product over axis

oleksandr-pavlyk

I think this PR is ready to go in. Subsequent development can be done in new PRs. Thank you @ndgrigorian !

github-actions · 2023-10-03T03:30:29Z

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_28 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

ndgrigorian force-pushed the feature/reductions-custom-ops branch from 29fb95f to 11f4c4a Compare September 11, 2023 21:07

ndgrigorian requested a review from oleksandr-pavlyk September 11, 2023 22:09

ndgrigorian force-pushed the feature/reductions-custom-ops branch from 9feca2d to 42d20e4 Compare September 15, 2023 07:44

ndgrigorian force-pushed the feature/reductions-custom-ops branch from 42d20e4 to 316b88a Compare September 19, 2023 01:29

ndgrigorian force-pushed the feature/reductions-custom-ops branch from 198785a to 4bb76a7 Compare September 22, 2023 04:00

ndgrigorian force-pushed the feature/reductions-custom-ops branch 2 times, most recently from 6d10437 to d1de259 Compare September 27, 2023 05:26

ndgrigorian force-pushed the feature/reductions-custom-ops branch 2 times, most recently from c3d1f62 to 1025b92 Compare September 27, 2023 17:38

ndgrigorian marked this pull request as ready for review September 28, 2023 01:47

ndgrigorian and others added 10 commits September 29, 2023 13:53

Argmin and argmax now handle identities correctly

97efe7a

Adds a test for this behavior Fixed a typo in argmin and argmax causing shared local memory variant to be used for more types than expected

Replaced std::min with idx_reduction_op_

7aef816

reductions now well-behaved for size-zero arrays

6c3abcc

- comparison and search reductions will throw an error in this case - slips in change to align sum signature with array API spec

removed unnecessary copies in reduction templates

a00ac58

Refactors sum to use generic reduction templates

2468d8a

Sum now uses a generic Python API

78829e7

Docstrings added for argmax, argmin, max, and min

f01991b

Small reduction clean-ups

8597300

Removed unnecessary copies in custom_reduce_over_group Sequential reduction now casts before calling operator (makes behavior explicit rather than implicit)

Added test for argmin with keepdims=True

2c18667

Added a test for raised errors in reductions

24b54d7

Also removed unused `_usm_types` in `test_tensor_sum`

ndgrigorian force-pushed the feature/reductions-custom-ops branch from 1cda64c to 24b54d7 Compare September 29, 2023 20:53

oleksandr-pavlyk reviewed Sep 30, 2023

View reviewed changes

dpctl/tensor/libtensor/include/utils/sycl_utils.hpp Outdated Show resolved Hide resolved

Removed void overloads from reduction utilities

df1c22f

These were unused by dpctl

oleksandr-pavlyk added 2 commits October 1, 2023 07:51

Adding functor factories for product over axis

0598416

oleksandr-pavlyk mentioned this pull request Oct 1, 2023

Implement product #1426

Merged

6 tasks

oleksandr-pavlyk and others added 6 commits October 1, 2023 08:21

Added Python API for _prod_over_axis

ca0ff64

Defined dpctl.tensor.prod

1d9b7ce

Also tweaked docstring for sum.

Added tests for dpt.prod, removed uses of numpy

8890d21

Corrected prod docstring

60a8ad7

Small tweaks to sum, min, and max docstrings

Merge pull request #1426 from IntelPython/implement-product

04ec23b

Implement product over axis

oleksandr-pavlyk approved these changes Oct 3, 2023

View reviewed changes

ndgrigorian merged commit 71e891c into master Oct 3, 2023

oleksandr-pavlyk deleted the feature/reductions-custom-ops branch October 27, 2023 02:23

oleksandr-pavlyk mentioned this pull request Jan 26, 2024

Populated changelog of new features since 0.15.0 release #1510

Merged

6 tasks

Conversation

ndgrigorian commented Sep 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 11, 2023

Uh oh!

coveralls commented Sep 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 11, 2023

Uh oh!

github-actions bot commented Sep 11, 2023

Uh oh!

github-actions bot commented Sep 14, 2023

Uh oh!

github-actions bot commented Sep 15, 2023

Uh oh!

github-actions bot commented Sep 15, 2023

Uh oh!

github-actions bot commented Sep 15, 2023

Uh oh!

github-actions bot commented Sep 15, 2023

Uh oh!

github-actions bot commented Sep 19, 2023

Uh oh!

github-actions bot commented Sep 19, 2023

Uh oh!

github-actions bot commented Sep 19, 2023

Uh oh!

github-actions bot commented Sep 22, 2023

Uh oh!

github-actions bot commented Sep 27, 2023

Uh oh!

github-actions bot commented Sep 27, 2023

Uh oh!

github-actions bot commented Sep 27, 2023

Uh oh!

github-actions bot commented Sep 27, 2023

Uh oh!

github-actions bot commented Sep 27, 2023

Uh oh!

github-actions bot commented Sep 28, 2023

Uh oh!

github-actions bot commented Sep 28, 2023

Uh oh!

github-actions bot commented Sep 29, 2023

Uh oh!

github-actions bot commented Sep 29, 2023

Uh oh!

Uh oh!

github-actions bot commented Oct 1, 2023

Uh oh!

oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ndgrigorian commented Sep 11, 2023 •

edited

Loading

coveralls commented Sep 11, 2023 •

edited

Loading