Skip to content
This repository was archived by the owner on May 17, 2026. It is now read-only.

COMP: Match CMake minimum required version to ITK's#100

Merged
thewtex merged 1 commit into
InsightSoftwareConsortium:masterfrom
jhlegarreta:MatchCMakeMinimumRequiredToITK
Jan 4, 2023
Merged

COMP: Match CMake minimum required version to ITK's#100
thewtex merged 1 commit into
InsightSoftwareConsortium:masterfrom
jhlegarreta:MatchCMakeMinimumRequiredToITK

Conversation

@jhlegarreta
Copy link
Copy Markdown
Member

Match CMake minimum required version to ITK's.

Fixes:

CMake Warning at D:/a/ITKTextureFeatures/ITK/CMake/ITKModuleExternal.cmake:12 (message):
-- cmake_minimum_required of 3.10.2 is not enough.
  cmake_minimum_required must be at least 3.16.3
Call Stack (most recent call first):
  CMakeLists.txt:8 (include)

-- This is needed to allow proper setting of CMAKE_MSVC_RUNTIME_LIBRARY.
-- Do not be surprised if you run into link errors of the style:
  LNK2038: mismatch detected for 'RuntimeLibrary': value 'MTd_Static' doesn't match value 'MDd_Dynamic' in module.obj
  cmake_minimum_required must be at least 3.16.3
Call Stack (most recent call first):
  CMakeLists.txt:21 (include)

raised for example at:
https://open.cdash.org/build/8374782/configure

Match CMake minimum required version to  ITK's.

Fixes:
```
CMake Warning at D:/a/ITKTextureFeatures/ITK/CMake/ITKModuleExternal.cmake:12 (message):
-- cmake_minimum_required of 3.10.2 is not enough.
  cmake_minimum_required must be at least 3.16.3
Call Stack (most recent call first):
  CMakeLists.txt:8 (include)

-- This is needed to allow proper setting of CMAKE_MSVC_RUNTIME_LIBRARY.
-- Do not be surprised if you run into link errors of the style:
  LNK2038: mismatch detected for 'RuntimeLibrary': value 'MTd_Static' doesn't match value 'MDd_Dynamic' in module.obj
  cmake_minimum_required must be at least 3.16.3
Call Stack (most recent call first):
  CMakeLists.txt:21 (include)
```

raised for example at:
https://open.cdash.org/build/8374782/configure
@jhlegarreta
Copy link
Copy Markdown
Member Author

Copy link
Copy Markdown
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thewtex thewtex merged commit e8a9020 into InsightSoftwareConsortium:master Jan 4, 2023
@jhlegarreta jhlegarreta deleted the MatchCMakeMinimumRequiredToITK branch January 4, 2023 01:46
@tbirdso
Copy link
Copy Markdown
Contributor

tbirdso commented Jan 4, 2023

Build errors unrelated to this patch set: https://github.com/InsightSoftwareConsortium/ITKTextureFeatures/actions/runs/3833844561/jobs/6525668696#step:5:129

Agreed that build errors are unrelated to this issue, looks like the ITK Linux build tarball download failed. Usually resolves on re-run.

 34 2002M   34  684M    0     0  12.3M      0  0:02:42  0:00:55  0:01:47     0
 34 2002M   34  684M    0     0  12.1M      0  0:02:44  0:00:56  0:01:48     0
curl: (92) HTTP/2 stream 0 was not closed cleanly: PROTOCOL_ERROR (err 1)
nylinux_2_28.tar.zst : Read error (39) : premature end 
Extracting files relevant for: cp38
tar: ITKPythonBuilds-linux-manylinux_2_28.tar: Cannot open: No such file or directory
tar: Error is not recoverable: exiting now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants