WIP: Validate PR #6322 dashboard cleanup on Azure CI#6323
Closed
hjmjohnson wants to merge 1 commit into
Closed
Conversation
…cleanup branch DO NOT MERGE. Retargets the "Download dashboard script" step in every Azure Pipelines YAML to clone hjmjohnson/ITK's dashboard-cleanup-objects-before-test branch instead of InsightSoftwareConsortium/ITK's dashboard branch. This is the only way to exercise the proposed itk_common.cmake change from PR InsightSoftwareConsortium#6322 on Azure CI without first landing InsightSoftwareConsortium#6322 on the upstream dashboard branch. When CI runs on this branch, the Azure pipelines will include the new "Free build-tree object files" fold between ctest_build and ctest_test. Observing that fold (or its absence on Windows MSVC, or on dashboard_continuous loops, or on coverage builds) validates the production behavior end-to-end. Revert this commit (or simply close this PR) once InsightSoftwareConsortium#6322 has been merged onto upstream/dashboard.
github-actions
Bot
added
type:Infrastructure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE. End-to-end validation rig for PR #6322 (the
itk_common.cmakepost-build/pre-test cleanup change).The Azure pipelines clone the dashboard helper script from
InsightSoftwareConsortium/ITK#dashboardin their "Download dashboard script" step. With #6322 still on the dashboard branch of my fork, Azure CI on a regularmainPR would not exercise it. This WIP retargets that clone in every Azure YAML tohjmjohnson/ITK#dashboard-cleanup-objects-before-test, so the Azure pipelines on this PR's HEAD run with the modifieditk_common.cmake.What to look at in CI output
In each Azure pipeline log, between the
BuildandTestsections, look for the new collapsible fold:When the fold is present, the cleanup matched files and removed them. When absent on a Windows MSVC pipeline, that's expected: this build either had no
.o/.a/.obj/.libto remove (e.g. partially-failed build) or the cleanup skipped due todashboard_continuous/dashboard_do_coverage.Cleanup checklist
When PR #6322 merges to upstream's
dashboardbranch:upstream/dashboardagain.